You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/23 18:07:21 UTC
[kudu-CR] dist-test: set TEST TMPDIR inside test directory
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5203
to review the following change.
Change subject: dist-test: set TEST_TMPDIR inside test directory
......................................................................
dist-test: set TEST_TMPDIR inside test directory
Recently I hit a case where I had a test which was crashing with an ASAN
warning halfway through, after writing a bunch of data into the test
tmpdir. Because we weren't setting TEST_TMPDIR in the dist-test
environment, the leftover data ended up orphaned in /tmp/kudutest-1000,
which wasn't cleaned up after the dist-test task ended.
This just sets the tmpdir to be inside the root working directory of the
test, so that we are guaranteed to clean it up after the test finishes.
To verify, I submitted a job and looked at the resulting test logs, and
saw that it was now writing within the test directory instead of within
/tmp/
Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
---
M build-support/run_dist_test.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5203/1
--
To view, visit http://gerrit.cloudera.org:8080/5203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: set TEST TMPDIR inside test directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5203
to look at the new patch set (#3).
Change subject: dist-test: set TEST_TMPDIR inside test directory
......................................................................
dist-test: set TEST_TMPDIR inside test directory
Recently I hit a case where I had a test which was crashing with an ASAN
warning halfway through, after writing a bunch of data into the test
tmpdir. Because we weren't setting TEST_TMPDIR in the dist-test
environment, the leftover data ended up orphaned in /tmp/kudutest-1000,
which wasn't cleaned up after the dist-test task ended.
This just sets the tmpdir to be inside the root working directory of the
test, so that we are guaranteed to clean it up after the test finishes.
To verify, I submitted a job and looked at the resulting test logs, and
saw that it was now writing within the test directory instead of within
/tmp/
Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
---
M build-support/run_dist_test.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/5203/3
--
To view, visit http://gerrit.cloudera.org:8080/5203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] dist-test: set TEST TMPDIR inside test directory
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: dist-test: set TEST_TMPDIR inside test directory
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5203/2/build-support/run_dist_test.py
File build-support/run_dist_test.py:
Line 133: # left in /tmp
Nit: terminate with a period.
--
To view, visit http://gerrit.cloudera.org:8080/5203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] dist-test: set TEST TMPDIR inside test directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: dist-test: set TEST_TMPDIR inside test directory
......................................................................
dist-test: set TEST_TMPDIR inside test directory
Recently I hit a case where I had a test which was crashing with an ASAN
warning halfway through, after writing a bunch of data into the test
tmpdir. Because we weren't setting TEST_TMPDIR in the dist-test
environment, the leftover data ended up orphaned in /tmp/kudutest-1000,
which wasn't cleaned up after the dist-test task ended.
This just sets the tmpdir to be inside the root working directory of the
test, so that we are guaranteed to clean it up after the test finishes.
To verify, I submitted a job and looked at the resulting test logs, and
saw that it was now writing within the test directory instead of within
/tmp/
Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
Reviewed-on: http://gerrit.cloudera.org:8080/5203
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/run_dist_test.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] dist-test: set TEST TMPDIR inside test directory
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: dist-test: set TEST_TMPDIR inside test directory
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0497591860f7e8b1ea18c1ee9b05becb282f6ec8
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No