[GitHub] [incubator-doris] liutang123 commented on a change in pull request #6321: Fix 6320 Optimize lock when check error storage

[GitBox <gi...@apache.org>]

liutang123 commented on a change in pull request #6321:
URL: https://github.com/apache/incubator-doris/pull/6321#discussion_r676121453



##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -562,13 +562,22 @@ OLAPStatus TabletManager::_drop_tablet_unlocked(TTabletId tablet_id, SchemaHash
 OLAPStatus TabletManager::drop_tablets_on_error_root_path(
         const std::vector<TabletInfo>& tablet_info_vec) {
     OLAPStatus res = OLAP_SUCCESS;
-    for (int32 i = 0; i < _tablets_shards_size; i++) {
+    if (tablet_info_vec.empty()) { // This is a high probability event
+        LOG(INFO) << "tablet_info_vec is empty, return directly.";

Review comment:
       ok， i will test this pr in our cluster. And then remove this log.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org