You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Rajith Siriwardana <ra...@gmail.com> on 2014/03/09 05:44:26 UTC
Review Request 18944: [OODT-669] Disabling resource monitor in Assignment
monitor feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/
-----------------------------------------------------------
Review request for oodt and Chris Mattmann.
Bugs: OODT-669
https://issues.apache.org/jira/browse/OODT-669
Repository: oodt
Description
-------
Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor
Diffs
-----
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649
trunk/resource/src/main/resources/resource.properties 1575649
trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION
trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION
Diff: https://reviews.apache.org/r/18944/diff/
Testing
-------
Disabled monitor with Assignment monitor was tested
Thanks,
Rajith Siriwardana
Re: Review Request 18944: [OODT-669] Disabling resource monitor in
Assignment monitor feature
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review45711
-----------------------------------------------------------
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java
<https://reviews.apache.org/r/18944/#comment80672>
Why do we need this class? I don't get it.
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java
<https://reviews.apache.org/r/18944/#comment80673>
don't get this change?
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java
<https://reviews.apache.org/r/18944/#comment80674>
what's up with this change?
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java
<https://reviews.apache.org/r/18944/#comment80675>
Ditto
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java
<https://reviews.apache.org/r/18944/#comment80676>
why all these spacing changes?
trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java
<https://reviews.apache.org/r/18944/#comment80677>
spacing change
trunk/resource/src/main/resources/resource.properties
<https://reviews.apache.org/r/18944/#comment80678>
shouldn't be disabled - we just need the code that was there before for AssignmentMonitor. Then we should have a GangliaAssignmentMonitor that you can enable - but we don't need a disabled version?
- Chris Mattmann
On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
>
> (Updated March 9, 2014, 4:44 a.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Bugs: OODT-669
> https://issues.apache.org/jira/browse/OODT-669
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor
>
>
> Diffs
> -----
>
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649
> trunk/resource/src/main/resources/resource.properties 1575649
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION
> trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18944/diff/
>
>
> Testing
> -------
>
> Disabled monitor with Assignment monitor was tested
>
>
> Thanks,
>
> Rajith Siriwardana
>
>
Re: Review Request 18944: [OODT-669] Disabling resource monitor in
Assignment monitor feature
Posted by Rajith Siriwardana <ra...@gmail.com>.
> On May 2, 2014, 9:20 p.m., Chris Mattmann wrote:
> > Rajith, I'm not sure I get this patch. Why do we have to disable the Resource monitor for this to work? We used to have an AssignmentMonitor that didn't need Ganglia up and running -- so we could simply set AssignmentMonitor as the default Monitor and we were good. What's changed?
Chris, earlier it was just generating bogus values in the AssignmentMonitor. but now it has the ability to use a dynamically asigned resource monitor (currenlty we have only Ganglia), according to [1] disabling Ganglia should happend at that level I guess. AssignmentMonitor contains things like governing the resource assignments like features so I guess it's a higher level, dynamic assignment of resource monitor is a level below that. So AssignmentMonitor to work there should be a ResourceMonitor assigned to it. Correct me if I'm wrong.
[1] https://cwiki.apache.org/confluence/display/OODT/Ganglia+plugin+for+CAS+Resource+Manager
- Rajith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review42060
-----------------------------------------------------------
On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
>
> (Updated March 9, 2014, 4:44 a.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Bugs: OODT-669
> https://issues.apache.org/jira/browse/OODT-669
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor
>
>
> Diffs
> -----
>
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649
> trunk/resource/src/main/resources/resource.properties 1575649
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION
> trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18944/diff/
>
>
> Testing
> -------
>
> Disabled monitor with Assignment monitor was tested
>
>
> Thanks,
>
> Rajith Siriwardana
>
>
Re: Review Request 18944: [OODT-669] Disabling resource monitor in
Assignment monitor feature
Posted by Chris Mattmann <ma...@apache.org>.
> On May 2, 2014, 9:20 p.m., Chris Mattmann wrote:
> > Rajith, I'm not sure I get this patch. Why do we have to disable the Resource monitor for this to work? We used to have an AssignmentMonitor that didn't need Ganglia up and running -- so we could simply set AssignmentMonitor as the default Monitor and we were good. What's changed?
>
> Rajith Siriwardana wrote:
> Chris, earlier it was just generating bogus values in the AssignmentMonitor. but now it has the ability to use a dynamically asigned resource monitor (currenlty we have only Ganglia), according to [1] disabling Ganglia should happend at that level I guess. AssignmentMonitor contains things like governing the resource assignments like features so I guess it's a higher level, dynamic assignment of resource monitor is a level below that. So AssignmentMonitor to work there should be a ResourceMonitor assigned to it. Correct me if I'm wrong.
>
> [1] https://cwiki.apache.org/confluence/display/OODT/Ganglia+plugin+for+CAS+Resource+Manager
Thanks Rajith I need to look and read about this. AssignmentMonitor didn't generate bogus values before -- it just generated values that were based on profiling rather than actual data collection. Subtle difference, but important to understand.
Anyhoo I will take a look!
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review42060
-----------------------------------------------------------
On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
>
> (Updated March 9, 2014, 4:44 a.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Bugs: OODT-669
> https://issues.apache.org/jira/browse/OODT-669
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor
>
>
> Diffs
> -----
>
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649
> trunk/resource/src/main/resources/resource.properties 1575649
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION
> trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18944/diff/
>
>
> Testing
> -------
>
> Disabled monitor with Assignment monitor was tested
>
>
> Thanks,
>
> Rajith Siriwardana
>
>
Re: Review Request 18944: [OODT-669] Disabling resource monitor in
Assignment monitor feature
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review42060
-----------------------------------------------------------
Rajith, I'm not sure I get this patch. Why do we have to disable the Resource monitor for this to work? We used to have an AssignmentMonitor that didn't need Ganglia up and running -- so we could simply set AssignmentMonitor as the default Monitor and we were good. What's changed?
- Chris Mattmann
On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
>
> (Updated March 9, 2014, 4:44 a.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Bugs: OODT-669
> https://issues.apache.org/jira/browse/OODT-669
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor
>
>
> Diffs
> -----
>
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649
> trunk/resource/src/main/resources/resource.properties 1575649
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION
> trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18944/diff/
>
>
> Testing
> -------
>
> Disabled monitor with Assignment monitor was tested
>
>
> Thanks,
>
> Rajith Siriwardana
>
>
Re: Review Request 18944: [OODT-669] Disabling resource monitor in
Assignment monitor feature
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review50140
-----------------------------------------------------------
Please see my attached patch.
- Chris Mattmann
On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
>
> (Updated March 9, 2014, 4:44 a.m.)
>
>
> Review request for oodt and Chris Mattmann.
>
>
> Bugs: OODT-669
> https://issues.apache.org/jira/browse/OODT-669
>
>
> Repository: oodt
>
>
> Description
> -------
>
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor
>
>
> Diffs
> -----
>
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649
> trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649
> trunk/resource/src/main/resources/resource.properties 1575649
> trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION
> trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18944/diff/
>
>
> Testing
> -------
>
> Disabled monitor with Assignment monitor was tested
>
>
> Thanks,
>
> Rajith Siriwardana
>
>