You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2015/12/22 14:47:46 UTC

[jira] [Commented] (LUCENE-6947) SortField.missingValue should not be public

    [ https://issues.apache.org/jira/browse/LUCENE-6947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068134#comment-15068134 ] 

Michael McCandless commented on LUCENE-6947:
--------------------------------------------

+1

> SortField.missingValue should not be public
> -------------------------------------------
>
>                 Key: LUCENE-6947
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6947
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: Trunk
>
>         Attachments: LUCENE-6947.patch
>
>
> Today we have SortField.setMissingValue that tries to perform validation of the missing value, except that given that SortField.missingValue is public, it is very easy to bypass it. Let's make it protected (some sub-classes use it) and add a getter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org