You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/02 08:09:54 UTC
[GitHub] [apisix-dashboard] codecov-io commented on pull request #952: fix: hack to fix the checking of `remote_addrs`
codecov-io commented on pull request #952:
URL: https://github.com/apache/apisix-dashboard/pull/952#issuecomment-737066048
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=h1) Report
> Merging [#952](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=desc) (738bf9d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/95f26122fee30d2fcbd18d98433b106c09e9bdca?el=desc) (95f2612) will **increase** coverage by `0.31%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/952/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #952 +/- ##
==========================================
+ Coverage 43.10% 43.41% +0.31%
==========================================
Files 18 18
Lines 1290 1299 +9
==========================================
+ Hits 556 564 +8
- Misses 642 643 +1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/952/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `58.04% <100.00%> (+2.96%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/952/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
| [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/952/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `51.42% <0.00%> (-0.19%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=footer). Last update [95f2612...738bf9d](https://codecov.io/gh/apache/apisix-dashboard/pull/952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org