You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/11/25 23:40:41 UTC

[GitHub] spark pull request #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/23137

    [SPARK-26169] Create DataFrameSetOperationsSuite

    ## What changes were proposed in this pull request?
    
    Create a new suite DataFrameSetOperationsSuite for the test cases of DataFrame/Dataset's set operations.
    
    Also, add test cases of NULL handling for Array Except and Array Intersect. 
    
    ## How was this patch tested?
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark setOpsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23137
    
----
commit 4544d7a8cfa5e645d6c4b944e1bb8d8b02eb0206
Author: gatorsmile <ga...@...>
Date:   2018-10-15T17:12:14Z

    fix

commit fa0b5be373ad3f3351847bcc4e9d32b9d14d67a1
Author: gatorsmile <ga...@...>
Date:   2018-10-16T17:46:04Z

    fix

commit 14a927d2ae6bc68ae3c2b8e65706c0c67ad4342d
Author: gatorsmile <ga...@...>
Date:   2018-11-25T23:30:34Z

    Merge remote-tracking branch 'upstream/master' into setOpsTest

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    **[Test build #99247 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99247/testReport)** for PR 23137 at commit [`14a927d`](https://github.com/apache/spark/commit/14a927d2ae6bc68ae3c2b8e65706c0c67ad4342d).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99256/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    **[Test build #99247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99247/testReport)** for PR 23137 at commit [`14a927d`](https://github.com/apache/spark/commit/14a927d2ae6bc68ae3c2b8e65706c0c67ad4342d).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    CC @cloud-fan 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    LGTM, pending Jenkins


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #23137: [SPARK-26169] Create DataFrameSetOperationsSuite

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/23137
  
    thanks, merging to master!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org