You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Alexander Saydakov <sa...@verizonmedia.com> on 2019/09/09 19:05:09 UTC
[VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Dear IPMC and Community,
This is a call for vote to release Apache DataSketches-cpp version
1.0.0-incubating
This is a C++ version of the DataSketches core library with Python bindings.
This is the first release of this component.
We are not going to release any artifacts besides the source code.
Results from the PPMC vote:
3 votes were cast. All of the votes were (+1). One of the votes was from a
mentor.
http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
The release candidate:
https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
Source repository:
https://github.com/apache/incubator-datasketches-cpp
Git tag for this release:
https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
The artifact has been signed with key:
pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
alsay@apache.org>
Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
The public signing key can be found in the KEYS file:
https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
Changes from the RC1:
- added license to make files
- building and running unit tests does not require pybind11 (dependency for
Python bindings)
- better build instructions
This library was intended to be header-only, but this goal was not fully
achieved yet with CPC sketch code. This work is in progress.
Building and running unit tests requires CppUnit.
Installing CppUnit on OSX: brew install cppunit
Installing CppUnit on RHEL: yum install cppunit-devel
There are currently two ways of building: using existing make files and
generating make files using cmake. Exsisting make files might not work on
all platforms or with all C++ compilers. Generating make files using cmake
should solve this problem, but it currently requires cmake version 3.12.0
or higher that might not be readily available as a package on all platforms.
Installing the latest cmake on OSX: brew install cmake
Building and running unit tests using existing make files:
$ make
$ make test
Building and running unit tests using cmake:
$ mkdir build
$ cd build
$ cmake ..
$ make
$ make test
Building Python bindings requires cmake 3.12 or higher and pybind11.
Please see the following document for details:
https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
This is the second stage vote. The vote will remain open for at least 72
hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
Alexander Saydakov
alsay@apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
@Justin Mclean <ju...@classsoftware.com> thanks for the comments!
@leerho <le...@gmail.com> and @Alexander I'll help you about it.
Kind Regards,
Furkan KAMACI
On Fri, Sep 20, 2019 at 4:51 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> >> I presume you mean "consider as an alternative". This means we
> wouldn't
> >> need the actual BSD-2-Clause license text in our LICENSE, nor would we
> need
> >> the "Copyright / attribution" statement as those would be in the link.
>
>
> You put a short bit of text giving the product name, versions, license,
> copyright and a text pointer to where in the release the full license text
> can be found, some projects put all teh license into a directory called
> license. Your mentors, should be able to provide more detail and some
> examples.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
The latest DS-java release reflects my understanding of what is required.
On Fri, Sep 27, 2019 at 11:39 AM Furkan KAMACI <fu...@gmail.com>
wrote:
> Hi Lee,
>
> Did you have a chance to target this?
>
> Kind Regards,
> Furkan KAMACI
>
>
> ---------- Forwarded message ---------
> From: Justin Mclean <ju...@classsoftware.com>
> Date: Fri, Sep 20, 2019 at 4:51 PM
> Subject: Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0
> [RC2]
> To: <ge...@incubator.apache.org>
>
>
> Hi,
>
> >> I presume you mean "consider as an alternative". This means we
> wouldn't
> >> need the actual BSD-2-Clause license text in our LICENSE, nor would we
> need
> >> the "Copyright / attribution" statement as those would be in the link.
>
>
> You put a short bit of text giving the product name, versions, license,
> copyright and a text pointer to where in the release the full license text
> can be found, some projects put all teh license into a directory called
> license. Your mentors, should be able to provide more detail and some
> examples.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
--
From my cell phone.
Fwd: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi Lee,
Did you have a chance to target this?
Kind Regards,
Furkan KAMACI
---------- Forwarded message ---------
From: Justin Mclean <ju...@classsoftware.com>
Date: Fri, Sep 20, 2019 at 4:51 PM
Subject: Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
To: <ge...@incubator.apache.org>
Hi,
>> I presume you mean "consider as an alternative". This means we wouldn't
>> need the actual BSD-2-Clause license text in our LICENSE, nor would we
need
>> the "Copyright / attribution" statement as those would be in the link.
You put a short bit of text giving the product name, versions, license,
copyright and a text pointer to where in the release the full license text
can be found, some projects put all teh license into a directory called
license. Your mentors, should be able to provide more detail and some
examples.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
>> I presume you mean "consider as an alternative". This means we wouldn't
>> need the actual BSD-2-Clause license text in our LICENSE, nor would we need
>> the "Copyright / attribution" statement as those would be in the link.
You put a short bit of text giving the product name, versions, license, copyright and a text pointer to where in the release the full license text can be found, some projects put all teh license into a directory called license. Your mentors, should be able to provide more detail and some examples.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Like this:
https://github.com/apache/incubator-datasketches-java/blob/master/LICENSE
On Thu, Sep 19, 2019 at 4:16 PM leerho <le...@gmail.com> wrote:
> Hi Justin,
>
> You might also want to consider taking the license text [2] and placing in
>> a text point and point to that from the license.
>
>
> I presume you mean "consider as an alternative". This means we wouldn't
> need the actual BSD-2-Clause license text in our LICENSE, nor would we need
> the "Copyright / attribution" statement as those would be in the link.
>
> Correct?
>
> Lee.
>
>
>
> On Thu, Sep 19, 2019 at 3:37 PM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
>> Hi,
>>
>> > In case you didn't get the attachments here are links to them:
>> >
>> > LICENSE
>> > <
>> https://github.com/apache/incubator-datasketches-java/blob/master/LICENSE
>> >
>>
>> If you look at the BSD license [1] you notice it includes a copyright
>> line I would include that in the correct place in the license, rather than
>> seperating it out. You might also want to consider taking the license text
>> [2] and placing in a text point and point to that from the license.
>>
>> > NOTICE
>> > <
>> https://github.com/apache/incubator-datasketches-java/blob/master/NOTICE>
>>
>> That looks good to me.
>>
>> Thanks,
>> Justin
>>
>>
>> 1. https://opensource.org/licenses/BSD-2-Clause
>> 2. https://github.com/Cyan4973/xxHash/blob/dev/LICENSE
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Hi Justin,
You might also want to consider taking the license text [2] and placing in
> a text point and point to that from the license.
I presume you mean "consider as an alternative". This means we wouldn't
need the actual BSD-2-Clause license text in our LICENSE, nor would we need
the "Copyright / attribution" statement as those would be in the link.
Correct?
Lee.
On Thu, Sep 19, 2019 at 3:37 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > In case you didn't get the attachments here are links to them:
> >
> > LICENSE
> > <
> https://github.com/apache/incubator-datasketches-java/blob/master/LICENSE>
>
> If you look at the BSD license [1] you notice it includes a copyright line
> I would include that in the correct place in the license, rather than
> seperating it out. You might also want to consider taking the license text
> [2] and placing in a text point and point to that from the license.
>
> > NOTICE
> > <
> https://github.com/apache/incubator-datasketches-java/blob/master/NOTICE>
>
> That looks good to me.
>
> Thanks,
> Justin
>
>
> 1. https://opensource.org/licenses/BSD-2-Clause
> 2. https://github.com/Cyan4973/xxHash/blob/dev/LICENSE
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> In case you didn't get the attachments here are links to them:
>
> LICENSE
> <https://github.com/apache/incubator-datasketches-java/blob/master/LICENSE>
If you look at the BSD license [1] you notice it includes a copyright line I would include that in the correct place in the license, rather than seperating it out. You might also want to consider taking the license text [2] and placing in a text point and point to that from the license.
> NOTICE
> <https://github.com/apache/incubator-datasketches-java/blob/master/NOTICE>
That looks good to me.
Thanks,
Justin
1. https://opensource.org/licenses/BSD-2-Clause
2. https://github.com/Cyan4973/xxHash/blob/dev/LICENSE
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
In case you didn't get the attachments here are links to them:
LICENSE
<https://github.com/apache/incubator-datasketches-java/blob/master/LICENSE>
NOTICE
<https://github.com/apache/incubator-datasketches-java/blob/master/NOTICE>
On Thu, Sep 19, 2019 at 10:40 AM leerho <le...@gmail.com> wrote:
> Hi Justin,
>
> My gmail account claims that I sent you and general a message with
> attachments, but apparently they are being filtered out by Apache's
> mail server.
>
> Is this the case?
>
> Lee.
>
> On Wed, Sep 18, 2019 at 4:08 PM leerho <le...@gmail.com> wrote:
>
>> Hi Justin,
>>
>> Thank you for your help, but we would like to be really clear on what you
>> have in mind in terms of proper content of the LICENSE and NOTICE files.
>>
>> Attached are the LICENSE and NOTICE from another one of our repos, but
>> the concept is the same as what Alex is trying to clarify:
>>
>> If these look ok to you, then we know exactly what we have to do.
>>
>> Thank you for your patience!
>>
>> Lee
>>
>>
>> On Wed, Sep 18, 2019 at 3:56 PM Alexander Saydakov <
>> saydakov@verizonmedia.com> wrote:
>>
>>> I am talking about the attribution: link to the original, link to our
>>> file
>>> or files where it is used. Currently this attribution is in the NOTICE.
>>> It
>>> is not duplicated in the LICENSE. Do you propose to move this attribution
>>> to the LICENSE or do you believe that it is not necessary?
>>> Thanks.
>>>
>>> On Wed, Sep 18, 2019 at 3:43 PM Justin Mclean <ju...@classsoftware.com>
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > > So do you propose to move it to the LICENSE or remove altogether?
>>> >
>>> > That information should already be part of the LICENSE file (for
>>> instance
>>> > as text of the MIT license will include the copyright line). There no
>>> need
>>> > for duplication, but if it is not it should be added there.
>>> >
>>> > Thanks,
>>> > Justin
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> > For additional commands, e-mail: general-help@incubator.apache.org
>>> >
>>> >
>>>
>>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Hi Justin,
My gmail account claims that I sent you and general a message with
attachments, but apparently they are being filtered out by Apache's
mail server.
Is this the case?
Lee.
On Wed, Sep 18, 2019 at 4:08 PM leerho <le...@gmail.com> wrote:
> Hi Justin,
>
> Thank you for your help, but we would like to be really clear on what you
> have in mind in terms of proper content of the LICENSE and NOTICE files.
>
> Attached are the LICENSE and NOTICE from another one of our repos, but the
> concept is the same as what Alex is trying to clarify:
>
> If these look ok to you, then we know exactly what we have to do.
>
> Thank you for your patience!
>
> Lee
>
>
> On Wed, Sep 18, 2019 at 3:56 PM Alexander Saydakov <
> saydakov@verizonmedia.com> wrote:
>
>> I am talking about the attribution: link to the original, link to our file
>> or files where it is used. Currently this attribution is in the NOTICE. It
>> is not duplicated in the LICENSE. Do you propose to move this attribution
>> to the LICENSE or do you believe that it is not necessary?
>> Thanks.
>>
>> On Wed, Sep 18, 2019 at 3:43 PM Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>> > Hi,
>> >
>> > > So do you propose to move it to the LICENSE or remove altogether?
>> >
>> > That information should already be part of the LICENSE file (for
>> instance
>> > as text of the MIT license will include the copyright line). There no
>> need
>> > for duplication, but if it is not it should be added there.
>> >
>> > Thanks,
>> > Justin
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>> >
>>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Hi Justin,
Thank you for your help, but we would like to be really clear on what you
have in mind in terms of proper content of the LICENSE and NOTICE files.
Attached are the LICENSE and NOTICE from another one of our repos, but the
concept is the same as what Alex is trying to clarify:
If these look ok to you, then we know exactly what we have to do.
Thank you for your patience!
Lee
On Wed, Sep 18, 2019 at 3:56 PM Alexander Saydakov <
saydakov@verizonmedia.com> wrote:
> I am talking about the attribution: link to the original, link to our file
> or files where it is used. Currently this attribution is in the NOTICE. It
> is not duplicated in the LICENSE. Do you propose to move this attribution
> to the LICENSE or do you believe that it is not necessary?
> Thanks.
>
> On Wed, Sep 18, 2019 at 3:43 PM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > > So do you propose to move it to the LICENSE or remove altogether?
> >
> > That information should already be part of the LICENSE file (for instance
> > as text of the MIT license will include the copyright line). There no
> need
> > for duplication, but if it is not it should be added there.
> >
> > Thanks,
> > Justin
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Alexander Saydakov <sa...@verizonmedia.com>.
I am talking about the attribution: link to the original, link to our file
or files where it is used. Currently this attribution is in the NOTICE. It
is not duplicated in the LICENSE. Do you propose to move this attribution
to the LICENSE or do you believe that it is not necessary?
Thanks.
On Wed, Sep 18, 2019 at 3:43 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > So do you propose to move it to the LICENSE or remove altogether?
>
> That information should already be part of the LICENSE file (for instance
> as text of the MIT license will include the copyright line). There no need
> for duplication, but if it is not it should be added there.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> So do you propose to move it to the LICENSE or remove altogether?
That information should already be part of the LICENSE file (for instance as text of the MIT license will include the copyright line). There no need for duplication, but if it is not it should be added there.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Alexander Saydakov <sa...@verizonmedia.com>.
So do you propose to move it to the LICENSE or remove altogether?
On Tue, Sep 17, 2019 at 6:11 PM Justin Mclean <ju...@gmail.com>
wrote:
> Hi.
> If that content was in a NOTICE from a 3rd party ALv2 bit of software you
> would include it, that is the case with Ratis. That is not the case with
> your project. This is ASF policy not a legal requirement. Again please read
> the links I've provided and ask your mentors for help.
> Thanks,
> Justin
>
> On Wed, 18 Sep 2019, 01:55 Alexander Saydakov, <sa...@verizonmedia.com>
> wrote:
>
> > > I would remove ALL content below line 9 ( currently lines 9 to 37), as
> > all of that is LICENSE information and belongs in the LICENSE file not
> > NOTICE
> >
> > Justin,
> > I am confused. Are you proposing to move all attribution from NOTICE to
> > LICENSE?
> > We were told by our lawyer that all attribution belongs to NOTICE, and
> > LICENSE should have applicable licenses only.
> >
> > I also see that you voted on Ratis saying that NOTICE is OK.
> > I am looking at their NOTICE, and it has attribution almost exactly like
> in
> > our NOTICE.
> > Could you clarify please?
> > Thank you.
> >
> > On Mon, Sep 16, 2019 at 5:15 PM leerho <le...@gmail.com> wrote:
> >
> > > Thank you Justin for your clarification!
> > >
> > > Thank you Dave for your vote!
> > >
> > > Lee.
> > >
> > > On Mon, Sep 16, 2019 at 4:56 PM Dave Fisher <wa...@apache.org> wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > I checked:
> > > > - incubating in name
> > > > - signatures and hashes file
> > > > - DISCLAIMER exists (WIP version)
> > > > - LICENSE present - note it is being fixed for next version
> > > > - NOTICE present - being fixed for next release.
> > > > - no unexpected binaries
> > > > - All source files have ASF headers with noted exceptions.
> > > > - Can compile on OSX (Mojave) and all tests pass (if one follows the
> > > > directions and uses the cmake variant.
> > > >
> > > > Regards,
> > > > Dave
> > > >
> > > > > On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <
> > > > saydakov@verizonmedia.com> wrote:
> > > > >
> > > > > Dear IPMC and Community,
> > > > >
> > > > > This is a call for vote to release Apache DataSketches-cpp version
> > > > > 1.0.0-incubating
> > > > >
> > > > > This is a C++ version of the DataSketches core library with Python
> > > > bindings.
> > > > >
> > > > > This is the first release of this component.
> > > > >
> > > > > We are not going to release any artifacts besides the source code.
> > > > >
> > > > > Results from the PPMC vote:
> > > > > 3 votes were cast. All of the votes were (+1). One of the votes was
> > > from
> > > > a
> > > > > mentor.
> > > > >
> > > >
> > >
> >
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
> > > > >
> > > > > The release candidate:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
> > > > >
> > > > > Source repository:
> > > > > https://github.com/apache/incubator-datasketches-cpp
> > > > >
> > > > > Git tag for this release:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
> > > > >
> > > > > The artifact has been signed with key:
> > > > > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING
> KEY)
> > <
> > > > > alsay@apache.org>
> > > > > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
> > > > >
> > > > > The public signing key can be found in the KEYS file:
> > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
> > > > >
> > > > > Changes from the RC1:
> > > > > - added license to make files
> > > > > - building and running unit tests does not require pybind11
> > (dependency
> > > > for
> > > > > Python bindings)
> > > > > - better build instructions
> > > > >
> > > > > This library was intended to be header-only, but this goal was not
> > > fully
> > > > > achieved yet with CPC sketch code. This work is in progress.
> > > > >
> > > > > Building and running unit tests requires CppUnit.
> > > > >
> > > > > Installing CppUnit on OSX: brew install cppunit
> > > > > Installing CppUnit on RHEL: yum install cppunit-devel
> > > > >
> > > > > There are currently two ways of building: using existing make files
> > and
> > > > > generating make files using cmake. Exsisting make files might not
> > work
> > > on
> > > > > all platforms or with all C++ compilers. Generating make files
> using
> > > > cmake
> > > > > should solve this problem, but it currently requires cmake version
> > > 3.12.0
> > > > > or higher that might not be readily available as a package on all
> > > > platforms.
> > > > >
> > > > > Installing the latest cmake on OSX: brew install cmake
> > > > >
> > > > > Building and running unit tests using existing make files:
> > > > > $ make
> > > > > $ make test
> > > > >
> > > > > Building and running unit tests using cmake:
> > > > > $ mkdir build
> > > > > $ cd build
> > > > > $ cmake ..
> > > > > $ make
> > > > > $ make test
> > > > >
> > > > > Building Python bindings requires cmake 3.12 or higher and
> pybind11.
> > > > > Please see the following document for details:
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
> > > > >
> > > > > This is the second stage vote. The vote will remain open for at
> least
> > > 72
> > > > > hours and at least 3 (+1) IPMC votes or a majority of (+1) are
> > > acquired.
> > > > >
> > > > > Please vote accordingly:
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove with the reason
> > > > >
> > > > > Thanks,
> > > > > Alexander Saydakov
> > > > > alsay@apache.org
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> > > > For additional commands, e-mail: dev-help@datasketches.apache.org
> > > >
> > > >
> > >
> >
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@gmail.com>.
Hi.
If that content was in a NOTICE from a 3rd party ALv2 bit of software you
would include it, that is the case with Ratis. That is not the case with
your project. This is ASF policy not a legal requirement. Again please read
the links I've provided and ask your mentors for help.
Thanks,
Justin
On Wed, 18 Sep 2019, 01:55 Alexander Saydakov, <sa...@verizonmedia.com>
wrote:
> > I would remove ALL content below line 9 ( currently lines 9 to 37), as
> all of that is LICENSE information and belongs in the LICENSE file not
> NOTICE
>
> Justin,
> I am confused. Are you proposing to move all attribution from NOTICE to
> LICENSE?
> We were told by our lawyer that all attribution belongs to NOTICE, and
> LICENSE should have applicable licenses only.
>
> I also see that you voted on Ratis saying that NOTICE is OK.
> I am looking at their NOTICE, and it has attribution almost exactly like in
> our NOTICE.
> Could you clarify please?
> Thank you.
>
> On Mon, Sep 16, 2019 at 5:15 PM leerho <le...@gmail.com> wrote:
>
> > Thank you Justin for your clarification!
> >
> > Thank you Dave for your vote!
> >
> > Lee.
> >
> > On Mon, Sep 16, 2019 at 4:56 PM Dave Fisher <wa...@apache.org> wrote:
> >
> > > +1 (binding)
> > >
> > > I checked:
> > > - incubating in name
> > > - signatures and hashes file
> > > - DISCLAIMER exists (WIP version)
> > > - LICENSE present - note it is being fixed for next version
> > > - NOTICE present - being fixed for next release.
> > > - no unexpected binaries
> > > - All source files have ASF headers with noted exceptions.
> > > - Can compile on OSX (Mojave) and all tests pass (if one follows the
> > > directions and uses the cmake variant.
> > >
> > > Regards,
> > > Dave
> > >
> > > > On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <
> > > saydakov@verizonmedia.com> wrote:
> > > >
> > > > Dear IPMC and Community,
> > > >
> > > > This is a call for vote to release Apache DataSketches-cpp version
> > > > 1.0.0-incubating
> > > >
> > > > This is a C++ version of the DataSketches core library with Python
> > > bindings.
> > > >
> > > > This is the first release of this component.
> > > >
> > > > We are not going to release any artifacts besides the source code.
> > > >
> > > > Results from the PPMC vote:
> > > > 3 votes were cast. All of the votes were (+1). One of the votes was
> > from
> > > a
> > > > mentor.
> > > >
> > >
> >
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
> > > >
> > > > The release candidate:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
> > > >
> > > > Source repository:
> > > > https://github.com/apache/incubator-datasketches-cpp
> > > >
> > > > Git tag for this release:
> > > >
> > >
> >
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
> > > >
> > > > The artifact has been signed with key:
> > > > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY)
> <
> > > > alsay@apache.org>
> > > > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
> > > >
> > > > The public signing key can be found in the KEYS file:
> > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
> > > >
> > > > Changes from the RC1:
> > > > - added license to make files
> > > > - building and running unit tests does not require pybind11
> (dependency
> > > for
> > > > Python bindings)
> > > > - better build instructions
> > > >
> > > > This library was intended to be header-only, but this goal was not
> > fully
> > > > achieved yet with CPC sketch code. This work is in progress.
> > > >
> > > > Building and running unit tests requires CppUnit.
> > > >
> > > > Installing CppUnit on OSX: brew install cppunit
> > > > Installing CppUnit on RHEL: yum install cppunit-devel
> > > >
> > > > There are currently two ways of building: using existing make files
> and
> > > > generating make files using cmake. Exsisting make files might not
> work
> > on
> > > > all platforms or with all C++ compilers. Generating make files using
> > > cmake
> > > > should solve this problem, but it currently requires cmake version
> > 3.12.0
> > > > or higher that might not be readily available as a package on all
> > > platforms.
> > > >
> > > > Installing the latest cmake on OSX: brew install cmake
> > > >
> > > > Building and running unit tests using existing make files:
> > > > $ make
> > > > $ make test
> > > >
> > > > Building and running unit tests using cmake:
> > > > $ mkdir build
> > > > $ cd build
> > > > $ cmake ..
> > > > $ make
> > > > $ make test
> > > >
> > > > Building Python bindings requires cmake 3.12 or higher and pybind11.
> > > > Please see the following document for details:
> > > >
> > >
> >
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
> > > >
> > > > This is the second stage vote. The vote will remain open for at least
> > 72
> > > > hours and at least 3 (+1) IPMC votes or a majority of (+1) are
> > acquired.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thanks,
> > > > Alexander Saydakov
> > > > alsay@apache.org
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> > > For additional commands, e-mail: dev-help@datasketches.apache.org
> > >
> > >
> >
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Alexander Saydakov <sa...@verizonmedia.com>.
> I would remove ALL content below line 9 ( currently lines 9 to 37), as
all of that is LICENSE information and belongs in the LICENSE file not
NOTICE
Justin,
I am confused. Are you proposing to move all attribution from NOTICE to
LICENSE?
We were told by our lawyer that all attribution belongs to NOTICE, and
LICENSE should have applicable licenses only.
I also see that you voted on Ratis saying that NOTICE is OK.
I am looking at their NOTICE, and it has attribution almost exactly like in
our NOTICE.
Could you clarify please?
Thank you.
On Mon, Sep 16, 2019 at 5:15 PM leerho <le...@gmail.com> wrote:
> Thank you Justin for your clarification!
>
> Thank you Dave for your vote!
>
> Lee.
>
> On Mon, Sep 16, 2019 at 4:56 PM Dave Fisher <wa...@apache.org> wrote:
>
> > +1 (binding)
> >
> > I checked:
> > - incubating in name
> > - signatures and hashes file
> > - DISCLAIMER exists (WIP version)
> > - LICENSE present - note it is being fixed for next version
> > - NOTICE present - being fixed for next release.
> > - no unexpected binaries
> > - All source files have ASF headers with noted exceptions.
> > - Can compile on OSX (Mojave) and all tests pass (if one follows the
> > directions and uses the cmake variant.
> >
> > Regards,
> > Dave
> >
> > > On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <
> > saydakov@verizonmedia.com> wrote:
> > >
> > > Dear IPMC and Community,
> > >
> > > This is a call for vote to release Apache DataSketches-cpp version
> > > 1.0.0-incubating
> > >
> > > This is a C++ version of the DataSketches core library with Python
> > bindings.
> > >
> > > This is the first release of this component.
> > >
> > > We are not going to release any artifacts besides the source code.
> > >
> > > Results from the PPMC vote:
> > > 3 votes were cast. All of the votes were (+1). One of the votes was
> from
> > a
> > > mentor.
> > >
> >
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
> > >
> > > The release candidate:
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
> > >
> > > Source repository:
> > > https://github.com/apache/incubator-datasketches-cpp
> > >
> > > Git tag for this release:
> > >
> >
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
> > >
> > > The artifact has been signed with key:
> > > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> > > alsay@apache.org>
> > > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
> > >
> > > The public signing key can be found in the KEYS file:
> > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
> > >
> > > Changes from the RC1:
> > > - added license to make files
> > > - building and running unit tests does not require pybind11 (dependency
> > for
> > > Python bindings)
> > > - better build instructions
> > >
> > > This library was intended to be header-only, but this goal was not
> fully
> > > achieved yet with CPC sketch code. This work is in progress.
> > >
> > > Building and running unit tests requires CppUnit.
> > >
> > > Installing CppUnit on OSX: brew install cppunit
> > > Installing CppUnit on RHEL: yum install cppunit-devel
> > >
> > > There are currently two ways of building: using existing make files and
> > > generating make files using cmake. Exsisting make files might not work
> on
> > > all platforms or with all C++ compilers. Generating make files using
> > cmake
> > > should solve this problem, but it currently requires cmake version
> 3.12.0
> > > or higher that might not be readily available as a package on all
> > platforms.
> > >
> > > Installing the latest cmake on OSX: brew install cmake
> > >
> > > Building and running unit tests using existing make files:
> > > $ make
> > > $ make test
> > >
> > > Building and running unit tests using cmake:
> > > $ mkdir build
> > > $ cd build
> > > $ cmake ..
> > > $ make
> > > $ make test
> > >
> > > Building Python bindings requires cmake 3.12 or higher and pybind11.
> > > Please see the following document for details:
> > >
> >
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
> > >
> > > This is the second stage vote. The vote will remain open for at least
> 72
> > > hours and at least 3 (+1) IPMC votes or a majority of (+1) are
> acquired.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > Alexander Saydakov
> > > alsay@apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> > For additional commands, e-mail: dev-help@datasketches.apache.org
> >
> >
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Thank you Justin for your clarification!
Thank you Dave for your vote!
Lee.
On Mon, Sep 16, 2019 at 4:56 PM Dave Fisher <wa...@apache.org> wrote:
> +1 (binding)
>
> I checked:
> - incubating in name
> - signatures and hashes file
> - DISCLAIMER exists (WIP version)
> - LICENSE present - note it is being fixed for next version
> - NOTICE present - being fixed for next release.
> - no unexpected binaries
> - All source files have ASF headers with noted exceptions.
> - Can compile on OSX (Mojave) and all tests pass (if one follows the
> directions and uses the cmake variant.
>
> Regards,
> Dave
>
> > On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <
> saydakov@verizonmedia.com> wrote:
> >
> > Dear IPMC and Community,
> >
> > This is a call for vote to release Apache DataSketches-cpp version
> > 1.0.0-incubating
> >
> > This is a C++ version of the DataSketches core library with Python
> bindings.
> >
> > This is the first release of this component.
> >
> > We are not going to release any artifacts besides the source code.
> >
> > Results from the PPMC vote:
> > 3 votes were cast. All of the votes were (+1). One of the votes was from
> a
> > mentor.
> >
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
> >
> > The release candidate:
> >
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
> >
> > Source repository:
> > https://github.com/apache/incubator-datasketches-cpp
> >
> > Git tag for this release:
> >
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
> >
> > The artifact has been signed with key:
> > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> > alsay@apache.org>
> > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
> >
> > The public signing key can be found in the KEYS file:
> > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
> >
> > Changes from the RC1:
> > - added license to make files
> > - building and running unit tests does not require pybind11 (dependency
> for
> > Python bindings)
> > - better build instructions
> >
> > This library was intended to be header-only, but this goal was not fully
> > achieved yet with CPC sketch code. This work is in progress.
> >
> > Building and running unit tests requires CppUnit.
> >
> > Installing CppUnit on OSX: brew install cppunit
> > Installing CppUnit on RHEL: yum install cppunit-devel
> >
> > There are currently two ways of building: using existing make files and
> > generating make files using cmake. Exsisting make files might not work on
> > all platforms or with all C++ compilers. Generating make files using
> cmake
> > should solve this problem, but it currently requires cmake version 3.12.0
> > or higher that might not be readily available as a package on all
> platforms.
> >
> > Installing the latest cmake on OSX: brew install cmake
> >
> > Building and running unit tests using existing make files:
> > $ make
> > $ make test
> >
> > Building and running unit tests using cmake:
> > $ mkdir build
> > $ cd build
> > $ cmake ..
> > $ make
> > $ make test
> >
> > Building Python bindings requires cmake 3.12 or higher and pybind11.
> > Please see the following document for details:
> >
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
> >
> > This is the second stage vote. The vote will remain open for at least 72
> > hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > Alexander Saydakov
> > alsay@apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Thank you Justin for your clarification!
Thank you Dave for your vote!
Lee.
On Mon, Sep 16, 2019 at 4:56 PM Dave Fisher <wa...@apache.org> wrote:
> +1 (binding)
>
> I checked:
> - incubating in name
> - signatures and hashes file
> - DISCLAIMER exists (WIP version)
> - LICENSE present - note it is being fixed for next version
> - NOTICE present - being fixed for next release.
> - no unexpected binaries
> - All source files have ASF headers with noted exceptions.
> - Can compile on OSX (Mojave) and all tests pass (if one follows the
> directions and uses the cmake variant.
>
> Regards,
> Dave
>
> > On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <
> saydakov@verizonmedia.com> wrote:
> >
> > Dear IPMC and Community,
> >
> > This is a call for vote to release Apache DataSketches-cpp version
> > 1.0.0-incubating
> >
> > This is a C++ version of the DataSketches core library with Python
> bindings.
> >
> > This is the first release of this component.
> >
> > We are not going to release any artifacts besides the source code.
> >
> > Results from the PPMC vote:
> > 3 votes were cast. All of the votes were (+1). One of the votes was from
> a
> > mentor.
> >
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
> >
> > The release candidate:
> >
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
> >
> > Source repository:
> > https://github.com/apache/incubator-datasketches-cpp
> >
> > Git tag for this release:
> >
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
> >
> > The artifact has been signed with key:
> > pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> > alsay@apache.org>
> > Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
> >
> > The public signing key can be found in the KEYS file:
> > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
> >
> > Changes from the RC1:
> > - added license to make files
> > - building and running unit tests does not require pybind11 (dependency
> for
> > Python bindings)
> > - better build instructions
> >
> > This library was intended to be header-only, but this goal was not fully
> > achieved yet with CPC sketch code. This work is in progress.
> >
> > Building and running unit tests requires CppUnit.
> >
> > Installing CppUnit on OSX: brew install cppunit
> > Installing CppUnit on RHEL: yum install cppunit-devel
> >
> > There are currently two ways of building: using existing make files and
> > generating make files using cmake. Exsisting make files might not work on
> > all platforms or with all C++ compilers. Generating make files using
> cmake
> > should solve this problem, but it currently requires cmake version 3.12.0
> > or higher that might not be readily available as a package on all
> platforms.
> >
> > Installing the latest cmake on OSX: brew install cmake
> >
> > Building and running unit tests using existing make files:
> > $ make
> > $ make test
> >
> > Building and running unit tests using cmake:
> > $ mkdir build
> > $ cd build
> > $ cmake ..
> > $ make
> > $ make test
> >
> > Building Python bindings requires cmake 3.12 or higher and pybind11.
> > Please see the following document for details:
> >
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
> >
> > This is the second stage vote. The vote will remain open for at least 72
> > hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > Alexander Saydakov
> > alsay@apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Dave Fisher <wa...@apache.org>.
+1 (binding)
I checked:
- incubating in name
- signatures and hashes file
- DISCLAIMER exists (WIP version)
- LICENSE present - note it is being fixed for next version
- NOTICE present - being fixed for next release.
- no unexpected binaries
- All source files have ASF headers with noted exceptions.
- Can compile on OSX (Mojave) and all tests pass (if one follows the directions and uses the cmake variant.
Regards,
Dave
> On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <sa...@verizonmedia.com> wrote:
>
> Dear IPMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp version
> 1.0.0-incubating
>
> This is a C++ version of the DataSketches core library with Python bindings.
>
> This is the first release of this component.
>
> We are not going to release any artifacts besides the source code.
>
> Results from the PPMC vote:
> 3 votes were cast. All of the votes were (+1). One of the votes was from a
> mentor.
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
>
> Source repository:
> https://github.com/apache/incubator-datasketches-cpp
>
> Git tag for this release:
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
>
> The artifact has been signed with key:
> pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
> Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
>
> The public signing key can be found in the KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
> Changes from the RC1:
> - added license to make files
> - building and running unit tests does not require pybind11 (dependency for
> Python bindings)
> - better build instructions
>
> This library was intended to be header-only, but this goal was not fully
> achieved yet with CPC sketch code. This work is in progress.
>
> Building and running unit tests requires CppUnit.
>
> Installing CppUnit on OSX: brew install cppunit
> Installing CppUnit on RHEL: yum install cppunit-devel
>
> There are currently two ways of building: using existing make files and
> generating make files using cmake. Exsisting make files might not work on
> all platforms or with all C++ compilers. Generating make files using cmake
> should solve this problem, but it currently requires cmake version 3.12.0
> or higher that might not be readily available as a package on all platforms.
>
> Installing the latest cmake on OSX: brew install cmake
>
> Building and running unit tests using existing make files:
> $ make
> $ make test
>
> Building and running unit tests using cmake:
> $ mkdir build
> $ cd build
> $ cmake ..
> $ make
> $ make test
>
> Building Python bindings requires cmake 3.12 or higher and pybind11.
> Please see the following document for details:
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
>
> This is the second stage vote. The vote will remain open for at least 72
> hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Alexander Saydakov
> alsay@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> We are still a bit uncertain what you mean by "license information" in the NOTICE file.
I would remove ALL content below line 9 ( currently lines 9 to 37), as all of that is LICENSE information and belongs in the LICENSE file not NOTICE.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by leerho <le...@gmail.com>.
Hi Justin,
We are still a bit uncertain what you mean by "license information" in the
NOTICE file.
Are you suggesting to remove the two single lines:
Copyright (C) 1998-2019 CERN for the benefit of the LHCb and ATLAS
collaborations
and
Copyright (c) 2017 Benjamin R. Jack ?
The rest of the content in this file (after the first 8 lines), is
organized by license type and the text under each license type
is to help the user locate where in our release code we leverage code of
that license type and where the original source code is. I don't consider
this location information as "license information". It is just helpful
location information to the relevant code.
Thanks,
Lee.
On Mon, Sep 16, 2019 at 1:29 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > I would like to clarify a few things:
> > - As I understand it is fine to deal with this going forward in the
> master,
>
> Yep that fine, you have my +1 on this release.
>
> > and we can proceed with this vote.
> > - You propose to add one line "Copyright (c) 2017 Benjamin R. Jack" right
> > after the header "MIT License" in the LICENSE file
>
> Yes, you need the full license text as given in the project, that includes
> the copyright line.
>
> > - You propose to remove something from the NOTICE file. What exactly?
>
> The information about 3rd party license information goes in the LICENSE
> file not NOTICE. Those links I provided in my previous email should help.
>
> > Headers with license types? Is this a legal concern or just to keep this
> > file as short as possible?
>
> It’s ASF policy. Yes it’s to keep the NOTICE file short as possible as it
> has an affect on downstream projects.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I would like to clarify a few things:
> - As I understand it is fine to deal with this going forward in the master,
Yep that fine, you have my +1 on this release.
> and we can proceed with this vote.
> - You propose to add one line "Copyright (c) 2017 Benjamin R. Jack" right
> after the header "MIT License" in the LICENSE file
Yes, you need the full license text as given in the project, that includes the copyright line.
> - You propose to remove something from the NOTICE file. What exactly?
The information about 3rd party license information goes in the LICENSE file not NOTICE. Those links I provided in my previous email should help.
> Headers with license types? Is this a legal concern or just to keep this
> file as short as possible?
It’s ASF policy. Yes it’s to keep the NOTICE file short as possible as it has an affect on downstream projects.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Alexander Saydakov <sa...@verizonmedia.com>.
Justin,
I would like to clarify a few things:
- As I understand it is fine to deal with this going forward in the master,
and we can proceed with this vote.
- You propose to add one line "Copyright (c) 2017 Benjamin R. Jack" right
after the header "MIT License" in the LICENSE file
- You propose to remove something from the NOTICE file. What exactly?
Headers with license types? Is this a legal concern or just to keep this
file as short as possible?
Thank you very much.
On Mon, Sep 16, 2019 at 12:43 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> HI,
>
> > This has been already fixed in the master, but after this release
> candidate
> > was created.
> >
> https://github.com/apache/incubator-datasketches-cpp/commit/0427232b9f6b34c3806223c06c3892028390c3c1
>
> You need to include the full text of the MIT license in LICENSE and that
> includes the copyright line. The license information should not be included
> in the NOTICE file. [1][2]
>
> Thanks,
> Justin
>
> 1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
> 2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> This has been already fixed in the master, but after this release candidate
> was created.
> https://github.com/apache/incubator-datasketches-cpp/commit/0427232b9f6b34c3806223c06c3892028390c3c1
You need to include the full text of the MIT license in LICENSE and that includes the copyright line. The license information should not be included in the NOTICE file. [1][2]
Thanks,
Justin
1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Alexander Saydakov <sa...@verizonmedia.com>.
> If some code license is unknown it's best to ask the author what is it,
or better still ask them to license it under a permissive license that’s
compatible with the Apache license. As well as the two items mentioned in
NOTICE you may also need to check the licenses of code in these files [1][2]
This has been already fixed in the master, but after this release candidate
was created.
https://github.com/apache/incubator-datasketches-cpp/commit/0427232b9f6b34c3806223c06c3892028390c3c1
Thank you for your vote.
On Sat, Sep 14, 2019 at 12:09 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in name
> - signatures and hashes file
> - DISCLAIMER exists (work in progress version)
> - LICENSE is missing information c
> - NOTICE include license information which should be in LICENSE (see below)
> - no unexpected binaries
> - All source files have ASF headers
> - Can compile on OSX (Mojave) and all tests pass
>
> If some code license is unknown it's best to ask the author what is it, or
> better still ask them to license it under a permissive license that’s
> compatible with the Apache license. As well as the two items mentioned in
> NOTICE you may also need to check the licenses of code in these files [1][2]
>
> Thanks,
> Justin
>
> 1. ./fi/include/reverse_purge_hash_map.hpp
> 2. ./fi/include/frequent_items_sketch.hpp
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes file
- DISCLAIMER exists (work in progress version)
- LICENSE is missing information c
- NOTICE include license information which should be in LICENSE (see below)
- no unexpected binaries
- All source files have ASF headers
- Can compile on OSX (Mojave) and all tests pass
If some code license is unknown it's best to ask the author what is it, or better still ask them to license it under a permissive license that’s compatible with the Apache license. As well as the two items mentioned in NOTICE you may also need to check the licenses of code in these files [1][2]
Thanks,
Justin
1. ./fi/include/reverse_purge_hash_map.hpp
2. ./fi/include/frequent_items_sketch.hpp
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me! (binding - carrying my vote)
Kind Regards,
Furkan KAMACI
On Mon, Sep 9, 2019 at 10:05 PM Alexander Saydakov <
saydakov@verizonmedia.com> wrote:
> Dear IPMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp version
> 1.0.0-incubating
>
> This is a C++ version of the DataSketches core library with Python
> bindings.
>
> This is the first release of this component.
>
> We are not going to release any artifacts besides the source code.
>
> Results from the PPMC vote:
> 3 votes were cast. All of the votes were (+1). One of the votes was from a
> mentor.
>
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
>
> Source repository:
> https://github.com/apache/incubator-datasketches-cpp
>
> Git tag for this release:
>
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
>
> The artifact has been signed with key:
> pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
> Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
>
> The public signing key can be found in the KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
> Changes from the RC1:
> - added license to make files
> - building and running unit tests does not require pybind11 (dependency for
> Python bindings)
> - better build instructions
>
> This library was intended to be header-only, but this goal was not fully
> achieved yet with CPC sketch code. This work is in progress.
>
> Building and running unit tests requires CppUnit.
>
> Installing CppUnit on OSX: brew install cppunit
> Installing CppUnit on RHEL: yum install cppunit-devel
>
> There are currently two ways of building: using existing make files and
> generating make files using cmake. Exsisting make files might not work on
> all platforms or with all C++ compilers. Generating make files using cmake
> should solve this problem, but it currently requires cmake version 3.12.0
> or higher that might not be readily available as a package on all
> platforms.
>
> Installing the latest cmake on OSX: brew install cmake
>
> Building and running unit tests using existing make files:
> $ make
> $ make test
>
> Building and running unit tests using cmake:
> $ mkdir build
> $ cd build
> $ cmake ..
> $ make
> $ make test
>
> Building Python bindings requires cmake 3.12 or higher and pybind11.
> Please see the following document for details:
>
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
>
> This is the second stage vote. The vote will remain open for at least 72
> hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Alexander Saydakov
> alsay@apache.org
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Dave Fisher <wa...@apache.org>.
+1 (binding)
I checked:
- incubating in name
- signatures and hashes file
- DISCLAIMER exists (WIP version)
- LICENSE present - note it is being fixed for next version
- NOTICE present - being fixed for next release.
- no unexpected binaries
- All source files have ASF headers with noted exceptions.
- Can compile on OSX (Mojave) and all tests pass (if one follows the directions and uses the cmake variant.
Regards,
Dave
> On Sep 9, 2019, at 12:05 PM, Alexander Saydakov <sa...@verizonmedia.com> wrote:
>
> Dear IPMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp version
> 1.0.0-incubating
>
> This is a C++ version of the DataSketches core library with Python bindings.
>
> This is the first release of this component.
>
> We are not going to release any artifacts besides the source code.
>
> Results from the PPMC vote:
> 3 votes were cast. All of the votes were (+1). One of the votes was from a
> mentor.
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
>
> Source repository:
> https://github.com/apache/incubator-datasketches-cpp
>
> Git tag for this release:
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
>
> The artifact has been signed with key:
> pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
> Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
>
> The public signing key can be found in the KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
> Changes from the RC1:
> - added license to make files
> - building and running unit tests does not require pybind11 (dependency for
> Python bindings)
> - better build instructions
>
> This library was intended to be header-only, but this goal was not fully
> achieved yet with CPC sketch code. This work is in progress.
>
> Building and running unit tests requires CppUnit.
>
> Installing CppUnit on OSX: brew install cppunit
> Installing CppUnit on RHEL: yum install cppunit-devel
>
> There are currently two ways of building: using existing make files and
> generating make files using cmake. Exsisting make files might not work on
> all platforms or with all C++ compilers. Generating make files using cmake
> should solve this problem, but it currently requires cmake version 3.12.0
> or higher that might not be readily available as a package on all platforms.
>
> Installing the latest cmake on OSX: brew install cmake
>
> Building and running unit tests using existing make files:
> $ make
> $ make test
>
> Building and running unit tests using cmake:
> $ mkdir build
> $ cd build
> $ cmake ..
> $ make
> $ make test
>
> Building Python bindings requires cmake 3.12 or higher and pybind11.
> Please see the following document for details:
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
>
> This is the second stage vote. The vote will remain open for at least 72
> hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Alexander Saydakov
> alsay@apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Gian Merlino <gi...@apache.org>.
+1 (binding)
- Tarball name is correct (project, version, "incubating").
- NOTICE, LICENSE, DISCLAIMER-WIP files are present.
- I didn't notice any LICENSE / NOTICE issues beyond what's already been
discussed in the thread.
- Verified .asc signatures and .sha512 checksums.
- git.properties is present and correct.
- Tarball contents match the expected git tag.
- Was able to build from source and run tests on macOS 10.14.6.
One file is missing a copyright header:
1) ./hll/include/hll.private.hpp
On Mon, Sep 9, 2019 at 12:05 PM Alexander Saydakov <
saydakov@verizonmedia.com> wrote:
> Dear IPMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp version
> 1.0.0-incubating
>
> This is a C++ version of the DataSketches core library with Python
> bindings.
>
> This is the first release of this component.
>
> We are not going to release any artifacts besides the source code.
>
> Results from the PPMC vote:
> 3 votes were cast. All of the votes were (+1). One of the votes was from a
> mentor.
>
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
>
> Source repository:
> https://github.com/apache/incubator-datasketches-cpp
>
> Git tag for this release:
>
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
>
> The artifact has been signed with key:
> pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
> Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
>
> The public signing key can be found in the KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
> Changes from the RC1:
> - added license to make files
> - building and running unit tests does not require pybind11 (dependency for
> Python bindings)
> - better build instructions
>
> This library was intended to be header-only, but this goal was not fully
> achieved yet with CPC sketch code. This work is in progress.
>
> Building and running unit tests requires CppUnit.
>
> Installing CppUnit on OSX: brew install cppunit
> Installing CppUnit on RHEL: yum install cppunit-devel
>
> There are currently two ways of building: using existing make files and
> generating make files using cmake. Exsisting make files might not work on
> all platforms or with all C++ compilers. Generating make files using cmake
> should solve this problem, but it currently requires cmake version 3.12.0
> or higher that might not be readily available as a package on all
> platforms.
>
> Installing the latest cmake on OSX: brew install cmake
>
> Building and running unit tests using existing make files:
> $ make
> $ make test
>
> Building and running unit tests using cmake:
> $ mkdir build
> $ cd build
> $ cmake ..
> $ make
> $ make test
>
> Building Python bindings requires cmake 3.12 or higher and pybind11.
> Please see the following document for details:
>
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
>
> This is the second stage vote. The vote will remain open for at least 72
> hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Alexander Saydakov
> alsay@apache.org
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me! (binding - carrying my vote)
Kind Regards,
Furkan KAMACI
On Mon, Sep 9, 2019 at 10:05 PM Alexander Saydakov <
saydakov@verizonmedia.com> wrote:
> Dear IPMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp version
> 1.0.0-incubating
>
> This is a C++ version of the DataSketches core library with Python
> bindings.
>
> This is the first release of this component.
>
> We are not going to release any artifacts besides the source code.
>
> Results from the PPMC vote:
> 3 votes were cast. All of the votes were (+1). One of the votes was from a
> mentor.
>
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
>
> Source repository:
> https://github.com/apache/incubator-datasketches-cpp
>
> Git tag for this release:
>
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
>
> The artifact has been signed with key:
> pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
> Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
>
> The public signing key can be found in the KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
> Changes from the RC1:
> - added license to make files
> - building and running unit tests does not require pybind11 (dependency for
> Python bindings)
> - better build instructions
>
> This library was intended to be header-only, but this goal was not fully
> achieved yet with CPC sketch code. This work is in progress.
>
> Building and running unit tests requires CppUnit.
>
> Installing CppUnit on OSX: brew install cppunit
> Installing CppUnit on RHEL: yum install cppunit-devel
>
> There are currently two ways of building: using existing make files and
> generating make files using cmake. Exsisting make files might not work on
> all platforms or with all C++ compilers. Generating make files using cmake
> should solve this problem, but it currently requires cmake version 3.12.0
> or higher that might not be readily available as a package on all
> platforms.
>
> Installing the latest cmake on OSX: brew install cmake
>
> Building and running unit tests using existing make files:
> $ make
> $ make test
>
> Building and running unit tests using cmake:
> $ mkdir build
> $ cd build
> $ cmake ..
> $ make
> $ make test
>
> Building Python bindings requires cmake 3.12 or higher and pybind11.
> Please see the following document for details:
>
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
>
> This is the second stage vote. The vote will remain open for at least 72
> hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Alexander Saydakov
> alsay@apache.org
>
Re: [VOTE] Release Apache DataSketches-cpp (incubating) 1.0.0 [RC2]
Posted by Gian Merlino <gi...@apache.org>.
+1 (binding)
- Tarball name is correct (project, version, "incubating").
- NOTICE, LICENSE, DISCLAIMER-WIP files are present.
- I didn't notice any LICENSE / NOTICE issues beyond what's already been
discussed in the thread.
- Verified .asc signatures and .sha512 checksums.
- git.properties is present and correct.
- Tarball contents match the expected git tag.
- Was able to build from source and run tests on macOS 10.14.6.
One file is missing a copyright header:
1) ./hll/include/hll.private.hpp
On Mon, Sep 9, 2019 at 12:05 PM Alexander Saydakov <
saydakov@verizonmedia.com> wrote:
> Dear IPMC and Community,
>
> This is a call for vote to release Apache DataSketches-cpp version
> 1.0.0-incubating
>
> This is a C++ version of the DataSketches core library with Python
> bindings.
>
> This is the first release of this component.
>
> We are not going to release any artifacts besides the source code.
>
> Results from the PPMC vote:
> 3 votes were cast. All of the votes were (+1). One of the votes was from a
> mentor.
>
> http://mail-archives.apache.org/mod_mbox/datasketches-dev/201909.mbox/thread
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/cpp/1.0.0-incubating-rc2/
>
> Source repository:
> https://github.com/apache/incubator-datasketches-cpp
>
> Git tag for this release:
>
> https://github.com/apache/incubator-datasketches-cpp/releases/tag/1.0.0-incubating-rc2
>
> The artifact has been signed with key:
> pub 4096R/A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
> Fingerprint=40A2 47F6 1E8C 6C75 678C 69C5 6848 6114 A8E8 B4E0
>
> The public signing key can be found in the KEYS file:
> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS
>
> Changes from the RC1:
> - added license to make files
> - building and running unit tests does not require pybind11 (dependency for
> Python bindings)
> - better build instructions
>
> This library was intended to be header-only, but this goal was not fully
> achieved yet with CPC sketch code. This work is in progress.
>
> Building and running unit tests requires CppUnit.
>
> Installing CppUnit on OSX: brew install cppunit
> Installing CppUnit on RHEL: yum install cppunit-devel
>
> There are currently two ways of building: using existing make files and
> generating make files using cmake. Exsisting make files might not work on
> all platforms or with all C++ compilers. Generating make files using cmake
> should solve this problem, but it currently requires cmake version 3.12.0
> or higher that might not be readily available as a package on all
> platforms.
>
> Installing the latest cmake on OSX: brew install cmake
>
> Building and running unit tests using existing make files:
> $ make
> $ make test
>
> Building and running unit tests using cmake:
> $ mkdir build
> $ cd build
> $ cmake ..
> $ make
> $ make test
>
> Building Python bindings requires cmake 3.12 or higher and pybind11.
> Please see the following document for details:
>
> https://github.com/apache/incubator-datasketches-cpp/blob/1.0.0-incubating-rc2/python/README.md
>
> This is the second stage vote. The vote will remain open for at least 72
> hours and at least 3 (+1) IPMC votes or a majority of (+1) are acquired.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> Alexander Saydakov
> alsay@apache.org
>