[GitHub] [superset] zhaoyongjie commented on a change in pull request #15153: feat: Adding a show all button to the column/metrics list in the explore view (Allow more than 50 columns to be shown)

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #15153:
URL: https://github.com/apache/superset/pull/15153#discussion_r659343457



##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -113,6 +125,11 @@ export default function DataSourcePanel({
     columns,
     metrics,
   });
+  const [showAllMetrics, setShowAllMetrics] = useState(false);
+  const [showAllColumns, setShowAllColumns] = useState(false);
+
+  const DEFAULT_MAX_COLUMNS_LENGTH = 50;

Review comment:
       Should we put these constants in the superset config, then access these values from store of redux `explore.common.conf.DEFAULT_MAX_COLUMNS_LENGTH` and `explore.common.conf.DEFAULT_MAX_METRICS_LENGTH`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org