You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "ganeshkumar269 (via GitHub)" <gi...@apache.org> on 2024/05/01 17:59:10 UTC
Re: [PR] feat: Implement Spark-compatible CAST between integer types [datafusion-comet]
ganeshkumar269 commented on PR #340:
URL: https://github.com/apache/datafusion-comet/pull/340#issuecomment-2088848565
Hi @andygrove , i have added a check before we fetch sparkInvalidValue, defaulting it to EMPTY_STRING if ':' is not present.
Also added additional comments on why we are checking for the presence of 'overflow' string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org