[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #208: chore: apisix-ingress v1.4

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #208:
URL: https://github.com/apache/apisix-helm-chart/pull/208#discussion_r792247169



##########
File path: charts/apisix-ingress-controller/templates/configmap.yaml
##########
@@ -20,7 +20,16 @@ data:
     # log options
     log_level: {{ .Values.config.logLevel | quote }}
     log_output: {{ .Values.config.logOutput | quote }}
+    cert_file: {{ .Values.config.certFile | quote }}
+    key_file: {{ .Values.config.keyFile | quote }}
     http_listen: {{ .Values.config.httpListen | quote }}
+    https_listen: {{ .Values.config.httpsListen | quote }}
+    {{- if gt (len .Values.config.kubernetes.appNamespaces) 0 }}

Review comment:
       Should be `(len .Values.config.kubernetes.ingressPublishService) 0`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org