You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Stuart Perks <st...@gmail.com> on 2020/12/17 12:19:27 UTC

SAMZA-2612: Kafka topic naming not supported fully

https://issues.apache.org/jira/browse/SAMZA-2612

Raised a bug JIRA but wanted to check with the community. Any thoughts would be great.


The StreamDescriptor class cannot accept all acceptable formats for Kafka Topic names.
StreamDescriptor
  private static final Pattern STREAM_ID_PATTERN = Pattern.compile("[\\d\\w-_]+");
Kafka Topic Validation
    public static final String LEGAL_CHARS = "[a-zA-Z0-9._-]";
Taking the example this is valid
 KafkaInputDescriptor<PageView> pageViewStreamDescriptor = kafkaSystemDescriptor.getInputDescriptor("page-view-topic", new JsonSerdeV2<>(PageView.class));
but this is not if we use the name page.view.topic as . Is not valid in the StreamDescriptor.
 KafkaInputDescriptor<PageView> pageViewStreamDescriptor = kafkaSystemDescriptor.getInputDescriptor("page.view.topic", new JsonSerdeV2<>(PageView.class));
Stream Descriptor Validation <https://github.com/apache/samza/blob/master/samza-api/src/main/java/org/apache/samza/system/descriptors/StreamDescriptor.java#L48>
Kafka Topic Validation <https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L29>