You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 23:36:00 UTC

[GitHub] [airflow] ferruzzi opened a new pull request, #25078: SageMaker system tests - Part 1 of 3 - Prep Work (AIP-47)

ferruzzi opened a new pull request, #25078:
URL: https://github.com/apache/airflow/pull/25078

   SageMaker Operators get a little cleaning up and prep work for system tests.
   
   Broken into three commits:
   
   [753df29](https://github.com/apache/airflow/commit/753df295a43658bd8ca2761294369b42c29fb4f6) 
   - No functional/logic changes, just adding some type hints and other tech debt
   
   [1a9d278](https://github.com/apache/airflow/commit/1a9d278605a3b82c3bc25f313fa306cb9ba382be) 
   - Refactor of the operator unit tests, including type hinting, variable name conventions, string quote style, etc 
   - Adds explicit unit testing for the integer_fields before making any changes to how they are handled.
   
   [b94fdb4](]https://github.com/apache/airflow/commit/b94fdb4dd49a012a70161be98616bd2080189f64)
   - Refactors the operator's integer_fields so they are configured at runtime.  This is a requirement for the system tests in a future PR to run.  The unit tests added in `1a9d278` all still pass, showing that the changes do not break existing code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #25078: SageMaker system tests - Part 1 of 3 - Prep Work (AIP-47)

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25078:
URL: https://github.com/apache/airflow/pull/25078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org