[jira] [Comment Edited] (CB-1453) Namespace issue of JSONKit (JSONKitSerializingBlockAdditions)

["Christoph Jerolimov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454396#comment-13454396 ] 

Christoph Jerolimov edited comment on CB-1453 at 9/13/12 8:45 AM:
------------------------------------------------------------------

Sorry, your right. I've copied the code from JSONKit instead from Cordova. I've updatet the issue. The problem is still there, because your link shows exactly the problem.

The cordova JSONKit clone defines the same namespace "JSONKitSerializingBlockAdditions" like the original JSONKit library: https://github.com/johnezang/JSONKit/blob/master/JSONKit.h#L237

So it could not be used in the same project. Fix fix this the categoryname must also prefixed like the methods or the other categories.
                
      was (Author: jerolimov):
    Your link shows exactly the namespace "JSONKitSerializingBlockAdditions" which is also used by the original JSONKit library: https://github.com/johnezang/JSONKit/blob/master/JSONKit.h#L237

This categoryname must also prefixed like the methods or the other categories.
                  
> Namespace issue of JSONKit (JSONKitSerializingBlockAdditions)
> -------------------------------------------------------------
>
>                 Key: CB-1453
>                 URL: https://issues.apache.org/jira/browse/CB-1453
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0
>         Environment: iOS
>            Reporter: Christoph Jerolimov
>
> In CB-1000 you've changed the namespace handling for the included library. But you missed this Category. So the build run still into duplicate warnings:
> {code}
> @interface NSDictionary (JSONKitSerializingBlockAdditions)
> - (NSData *)cdv_JSONDataWithOptions:(CDVJKSerializeOptionFlags)serializeOptions serializeUnsupportedClassesUsingBlock:(id(^)(id object))block error:(NSError **)error;
> - (NSString *)cdv_JSONStringWithOptions:(CDVJKSerializeOptionFlags)serializeOptions serializeUnsupportedClassesUsingBlock:(id(^)(id object))block error:(NSError **)error;
> @end
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira