[GitHub] [geode] mcmellawatt opened pull request #2883: GEODE-6065: Continue event processing when hostname lookup fails

["mcmellawatt (GitHub)" <gi...@apache.org>]

Throw a ServerConnectivityException instead of a GemFireConfigException when hostname lookup fails because:

1) The WAN event processor will sleep and retry on ServerConnectivityException, but will shut down due to the a GemFireConfigException.  In this case, we are dealing with an intermittent failure to lookup an IP address by hostname, so we should sleep and retry.

2) ServerConnectivityException conceptually makes more sense.  GemFireConfigException is intended for issues involving configuration i.e. cache.xml.

Co-authored-by: Bill Burcham <bb...@pivotal.io>
Co-authored-by: Ryan McMahon <rm...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- N/A If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2883 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on pull request #2883: GEODE-6065: Continue event processing when hostname lookup fails

["nabarunnag (GitHub)" <gi...@apache.org>]

Fix looks good to me.
But here just wanted to confirm that the visibility of the class was made public so that it can be mocked in a test class ? is that correct?

[ Full content available at: https://github.com/apache/geode/pull/2883 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #2883: GEODE-6065: Continue event processing when hostname lookup fails

["mcmellawatt (GitHub)" <gi...@apache.org>]

[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/2883 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2883: GEODE-6065: Continue event processing when hostname lookup fails

["mcmellawatt (GitHub)" <gi...@apache.org>]

That is correct.  The reason for this is the ConnectionManagerImpl asserts that the Connection is a PooledConnection, and we are encountering that assert in our test.  See `ConnectionManagerImpl.returnConnection()` and `ConnectionManagerImpl.exchangeConnection()`

[ Full content available at: https://github.com/apache/geode/pull/2883 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2883: GEODE-6065: Continue event processing when hostname lookup fails

["mcmellawatt (GitHub)" <gi...@apache.org>]

That is correct.  The reason for this is the `ConnectionManagerImpl` asserts that the `Connection` is a `PooledConnection`, and we are encountering that assert in our test.  See `ConnectionManagerImpl.returnConnection()` and `ConnectionManagerImpl.exchangeConnection()`

[ Full content available at: https://github.com/apache/geode/pull/2883 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org