You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by trixpan <gi...@git.apache.org> on 2016/10/07 05:27:54 UTC
[GitHub] nifi-minifi-cpp pull request #18: MINIFI-34 - attempt to progress the CMake ...
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/18
MINIFI-34 - attempt to progress the CMake environment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi-minifi-cpp cmake_woes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 9cb84cf65e16d55a8652259159ae4785eabc925a
Author: Aldrin Piri <al...@apache.org>
Date: 2016-05-05T21:32:57Z
MINIFI-34 Establishing CMake build system to provide build functionality equivalent to pre-existing Makefile.
commit 253c7c42ba94f11720f276b024630af4765bbf44
Author: Aldrin Piri <al...@apache.org>
Date: 2016-10-06T14:52:34Z
Updating .travis.yml to support CMake build system.
commit 2251ecce3833d3ac134d7004bee1e07f67f9cbdd
Author: Aldrin Piri <al...@apache.org>
Date: 2016-10-06T20:41:34Z
Adjusting travis build.
commit df11017e4ddd67e86271d67cd141eab610555355
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2016-10-07T04:40:20Z
MINIFI-34 - Adjust CMake files to succeed in RHEL6 and Ubuntu
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp pull request #18: MINIFI-34 - attempt to progress the CMake ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
Sounds fair to me. Indeed we have some obstacles to conquer handling all the varied environments but as you mentioned, the lessons learned should be a great help to folks who wish to build on their machine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
@apiri should we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
@apiri indeed. solving the INTERFACE was a matter of using what seems to be called the "infamous `dummy.cpp `".
Good news is that this should be working now (it works locally).
once you confirm travis-ci precise is working, I will be happy to proceed with enabling trusty tahr again and setup a docker based test to ease cross platform development.
Major changes of the last commit
- the CMake has been adjusted to compile against existing libuuid
- travis adjusted to use whatever version of libboost-all-dev is available
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
Hmm, okay. Good information and agree on supporting the listed environments. I think I can work around the INTERFACE usage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
@apiri we are very close.
The current issue now is the use of `INTERFACE `(libminifi). This feature is only available when running CMake 3 (not available on RHEL6 and also not on Ubuntu LTS).
Also, you will see a few adjustments around `VERSION`.
The CMake policy required for that to work is not available on CMake 2.x (again, RHEL6 & Ubuntu LTS), reason why we saw [this](https://travis-ci.org/apache/nifi-minifi-cpp/builds/165648184#L629):
I left the code as a condition but I reckon we will have to get rid of it in the long run in order to achieve better compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
ok. So precise(12.04) does not work out of the box, only with add on packages.
I think we should push this with 14.04 (travis' `dist: tahr`) and add 12.04 as a docker container for testing. This should also help documenting the required compilation steps on 12.04
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/18
Yeah, seems like we have a good start. Will do some testing around on a few systems and get it merged in today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---