You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by OmPrakash Muppirala <bi...@gmail.com> on 2014/07/25 02:34:53 UTC
[LAZY] Enabling Github pull requests in Apache Flex
The INFRA team has started supporting [1] pull requests from github. If no
one has objections, I will open a ticket with INFRA to enable this feature
for Apache Flex. In particular, these are the benefits we get from opting
in for the tighter GitHub integration
- Any Pull Request that gets opened, closed, reopened or commented on
now gets recorded on the project's mailing list
- If a project has a JIRA instance, any PRs or comments on PRs that
include a JIRA ticket ID will trigger an update on that specific ticket
- Replying to a GitHub comment on the dev@ mailing list will trigger a
comment being placed on GitHub (yes, it works both ways!)
- GitHub activity can now be relayed to IRC channels on the Freenode
network.
This means that we can actually accept pull requests from GitHub going
forward.
Thanks,
Om
[1]
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
RE: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Maurice Amsellem <ma...@systar.com>.
Is this a vote thread? If so +1 for me
-----Message d'origine-----
De : omuppi1@gmail.com [mailto:omuppi1@gmail.com] De la part de OmPrakash Muppirala
Envoyé : vendredi 25 juillet 2014 02:35
À : dev@flex.apache.org
Objet : [LAZY] Enabling Github pull requests in Apache Flex
The INFRA team has started supporting [1] pull requests from github. If no one has objections, I will open a ticket with INFRA to enable this feature for Apache Flex. In particular, these are the benefits we get from opting in for the tighter GitHub integration
- Any Pull Request that gets opened, closed, reopened or commented on
now gets recorded on the project's mailing list
- If a project has a JIRA instance, any PRs or comments on PRs that
include a JIRA ticket ID will trigger an update on that specific ticket
- Replying to a GitHub comment on the dev@ mailing list will trigger a
comment being placed on GitHub (yes, it works both ways!)
- GitHub activity can now be relayed to IRC channels on the Freenode
network.
This means that we can actually accept pull requests from GitHub going forward.
Thanks,
Om
[1]
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
RE: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Frédéric THOMAS <we...@hotmail.com>.
Nice feature to have !
Frédéric THOMAS
> From: bigosmallm@gmail.com
> Date: Thu, 24 Jul 2014 17:34:53 -0700
> Subject: [LAZY] Enabling Github pull requests in Apache Flex
> To: dev@flex.apache.org
>
> The INFRA team has started supporting [1] pull requests from github. If no
> one has objections, I will open a ticket with INFRA to enable this feature
> for Apache Flex. In particular, these are the benefits we get from opting
> in for the tighter GitHub integration
>
> - Any Pull Request that gets opened, closed, reopened or commented on
> now gets recorded on the project's mailing list
> - If a project has a JIRA instance, any PRs or comments on PRs that
> include a JIRA ticket ID will trigger an update on that specific ticket
> - Replying to a GitHub comment on the dev@ mailing list will trigger a
> comment being placed on GitHub (yes, it works both ways!)
> - GitHub activity can now be relayed to IRC channels on the Freenode
> network.
>
> This means that we can actually accept pull requests from GitHub going
> forward.
>
> Thanks,
> Om
>
> [1]
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Chris Martin <wi...@gmail.com>.
I think this would be very cool.
Chris
On Thu, Jul 24, 2014 at 5:34 PM, OmPrakash Muppirala <bi...@gmail.com>
wrote:
> The INFRA team has started supporting [1] pull requests from github. If no
> one has objections, I will open a ticket with INFRA to enable this feature
> for Apache Flex. In particular, these are the benefits we get from opting
> in for the tighter GitHub integration
>
> - Any Pull Request that gets opened, closed, reopened or commented on
> now gets recorded on the project's mailing list
> - If a project has a JIRA instance, any PRs or comments on PRs that
> include a JIRA ticket ID will trigger an update on that specific ticket
> - Replying to a GitHub comment on the dev@ mailing list will trigger a
> comment being placed on GitHub (yes, it works both ways!)
> - GitHub activity can now be relayed to IRC channels on the Freenode
> network.
>
> This means that we can actually accept pull requests from GitHub going
> forward.
>
> Thanks,
> Om
>
> [1]
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Alex Harui <ah...@adobe.com>.
On 9/5/14 11:18 AM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>Can you make me a moderator?
No. Only Infra can. I have requested that you get added as moderator to
dev@. If you want to moderate others, let me know.
-Alex
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Can you make me a moderator?
Thanks,
Om
On Fri, Sep 5, 2014 at 11:14 AM, Alex Harui <ah...@adobe.com> wrote:
> Technically, there are several moderators on dev@ who are faster at
> moderating than I am. Last one I saw from git@git.a.o was titled
> "[GitHub] flex-sdk pull request: Fix MenuBar.styleChanged() crash bug" and
> from you.
>
> I think there were 3 total with that subject.
>
> If another PR gets processed, theoretically the moderators won't have to
> get involved.
>
> -Alex
>
> On 9/5/14 11:07 AM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >I am not sure I saw the emails. What was the last email you moderated
> >through?
> >
> >Thanks,
> >Om
> >
> >
> >On Thu, Sep 4, 2014 at 10:50 PM, Alex Harui <ah...@adobe.com> wrote:
> >
> >> OK, that should be done now. Is everything else working as expected?
> >>
> >> On 9/4/14 10:31 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
> >>
> >> >On Sep 4, 2014 10:23 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >> >>
> >> >> I saw another email from git@git.a.o. Is that involved in this
> >> process?
> >> >> Should we allow that one as well?
> >> >>
> >> >
> >> >Yes the other one is also part of making GitHub more integrated with
> >>our
> >> >dev workflow. Please allow that as well.
> >> >
> >> >Thanks,
> >> >Om
> >> >
> >> >> On 9/4/14 3:42 PM, "OmPrakash Muppirala" <bi...@gmail.com>
> >>wrote:
> >> >>
> >> >> >I saw one email on dev. Was that the one?
> >> >> >
> >> >> >
> >> >> >On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean
> >> >><ju...@classsoftware.com>
> >> >> >wrote:
> >> >> >
> >> >> >> Hi,
> >> >> >>
> >> >> >> > Can you check if there are any emails stuck in moderation?
> >> >> >>
> >> >> >> There was one.
> >> >> >>
> >> >> >> Justin
> >> >> >>
> >> >>
> >>
> >>
>
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Alex Harui <ah...@adobe.com>.
Technically, there are several moderators on dev@ who are faster at
moderating than I am. Last one I saw from git@git.a.o was titled
"[GitHub] flex-sdk pull request: Fix MenuBar.styleChanged() crash bug" and
from you.
I think there were 3 total with that subject.
If another PR gets processed, theoretically the moderators won't have to
get involved.
-Alex
On 9/5/14 11:07 AM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>I am not sure I saw the emails. What was the last email you moderated
>through?
>
>Thanks,
>Om
>
>
>On Thu, Sep 4, 2014 at 10:50 PM, Alex Harui <ah...@adobe.com> wrote:
>
>> OK, that should be done now. Is everything else working as expected?
>>
>> On 9/4/14 10:31 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>>
>> >On Sep 4, 2014 10:23 PM, "Alex Harui" <ah...@adobe.com> wrote:
>> >>
>> >> I saw another email from git@git.a.o. Is that involved in this
>> process?
>> >> Should we allow that one as well?
>> >>
>> >
>> >Yes the other one is also part of making GitHub more integrated with
>>our
>> >dev workflow. Please allow that as well.
>> >
>> >Thanks,
>> >Om
>> >
>> >> On 9/4/14 3:42 PM, "OmPrakash Muppirala" <bi...@gmail.com>
>>wrote:
>> >>
>> >> >I saw one email on dev. Was that the one?
>> >> >
>> >> >
>> >> >On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean
>> >><ju...@classsoftware.com>
>> >> >wrote:
>> >> >
>> >> >> Hi,
>> >> >>
>> >> >> > Can you check if there are any emails stuck in moderation?
>> >> >>
>> >> >> There was one.
>> >> >>
>> >> >> Justin
>> >> >>
>> >>
>>
>>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I am not sure I saw the emails. What was the last email you moderated
through?
Thanks,
Om
On Thu, Sep 4, 2014 at 10:50 PM, Alex Harui <ah...@adobe.com> wrote:
> OK, that should be done now. Is everything else working as expected?
>
> On 9/4/14 10:31 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >On Sep 4, 2014 10:23 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >>
> >> I saw another email from git@git.a.o. Is that involved in this
> process?
> >> Should we allow that one as well?
> >>
> >
> >Yes the other one is also part of making GitHub more integrated with our
> >dev workflow. Please allow that as well.
> >
> >Thanks,
> >Om
> >
> >> On 9/4/14 3:42 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
> >>
> >> >I saw one email on dev. Was that the one?
> >> >
> >> >
> >> >On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean
> >><ju...@classsoftware.com>
> >> >wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> > Can you check if there are any emails stuck in moderation?
> >> >>
> >> >> There was one.
> >> >>
> >> >> Justin
> >> >>
> >>
>
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Alex Harui <ah...@adobe.com>.
OK, that should be done now. Is everything else working as expected?
On 9/4/14 10:31 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>On Sep 4, 2014 10:23 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>
>> I saw another email from git@git.a.o. Is that involved in this process?
>> Should we allow that one as well?
>>
>
>Yes the other one is also part of making GitHub more integrated with our
>dev workflow. Please allow that as well.
>
>Thanks,
>Om
>
>> On 9/4/14 3:42 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>>
>> >I saw one email on dev. Was that the one?
>> >
>> >
>> >On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean
>><ju...@classsoftware.com>
>> >wrote:
>> >
>> >> Hi,
>> >>
>> >> > Can you check if there are any emails stuck in moderation?
>> >>
>> >> There was one.
>> >>
>> >> Justin
>> >>
>>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Sep 4, 2014 10:23 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> I saw another email from git@git.a.o. Is that involved in this process?
> Should we allow that one as well?
>
Yes the other one is also part of making GitHub more integrated with our
dev workflow. Please allow that as well.
Thanks,
Om
> On 9/4/14 3:42 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >I saw one email on dev. Was that the one?
> >
> >
> >On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean <ju...@classsoftware.com>
> >wrote:
> >
> >> Hi,
> >>
> >> > Can you check if there are any emails stuck in moderation?
> >>
> >> There was one.
> >>
> >> Justin
> >>
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Alex Harui <ah...@adobe.com>.
I saw another email from git@git.a.o. Is that involved in this process?
Should we allow that one as well?
On 9/4/14 3:42 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>I saw one email on dev. Was that the one?
>
>
>On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean <ju...@classsoftware.com>
>wrote:
>
>> Hi,
>>
>> > Can you check if there are any emails stuck in moderation?
>>
>> There was one.
>>
>> Justin
>>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I saw one email on dev. Was that the one?
On Thu, Sep 4, 2014 at 3:39 PM, Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > Can you check if there are any emails stuck in moderation?
>
> There was one.
>
> Justin
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Can you check if there are any emails stuck in moderation?
There was one.
Justin
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Alex, I just gave it a couple of tries. I havent seen any email on the
dev@f.a.o list yet. Can you check if there are any emails stuck in
moderation?
Thanks,
Om
On Wed, Sep 3, 2014 at 8:53 PM, Alex Harui <ah...@adobe.com> wrote:
> Odd, it took almost an hour for the robot to respond. It should be in
> place, so give it a try.
>
> -Alex
>
> On 9/3/14 3:11 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>
> >I just got word from INFRA that the hooks have been deployed.
> >
> >Alex, can you please subscribe asfbot@urd.zones.apache.org to the dev@
> >mailing list so that the "reply-to" feature enabled?
> >
> >Once that is done, we can start testing the workflow.
> >
> >Thanks,
> >Om
> >
> >
> >On Fri, Aug 1, 2014 at 11:44 AM, OmPrakash Muppirala
> ><bi...@gmail.com>
> >wrote:
> >
> >> I have created a JIRA ticket for Infra for this integration [1] I will
> >> send an update when this gets done.
> >>
> >> Thanks,
> >> Om
> >>
> >> [1] https://issues.apache.org/jira/browse/INFRA-8140
> >>
> >>
> >> On Mon, Jul 28, 2014 at 9:52 AM, OmPrakash Muppirala
> >><bigosmallm@gmail.com
> >> > wrote:
> >>
> >>> On Mon, Jul 28, 2014 at 2:46 AM, Christofer Dutz <
> >>> christofer.dutz@c-ware.de> wrote:
> >>>
> >>>> Gee .. why didn't I get the original post ...
> >>>>
> >>>> so if the comment tracking is handled, I'm fine with that ... but
> >>>>still
> >>>> it sounds as if the workflow is still not smooth. As far as I know
> >>>>you have
> >>>> to have access to the account that recieves the pull request in order
> >>>>to
> >>>> apply it. If you don't you have to manually pull the changes, apply
> >>>>them
> >>>> youself and the initiating user hast to manually delete them ... or
> >>>>has
> >>>> Infra put any work into this?
> >>>>
> >>>> Chris
> >>>>
> >>>>
> >>> Yes, the workflow would be like this:
> >>>
> >>> 1. A non-committer forks the flex-sdk (or other repos) at
> >>> https://github.com/apache/flex-sdk
> >>> 2. They make some changes and generate a Pull Request (PR)
> >>> 3. The PR notification is forwarded to dev@flex.apache.org
> >>> 4. Folks can comment on/review the PR by replying to thread
> >>> 5. The comments are forwarded to the Github PR page
> >>> 6. An Apache Flex committer gets a patch version of the PR and
> >>> integrates it into the flex-sdk repo on ASF git.
> >>> 7. This gets merged into github.com/apache/flex-sdk
> >>> 8. The committer then responds to the thread on dev@flex.apache.org
> >>> asking the creator of the PR to close it.
> >>>
> >>> This process would make for better community involvement and not
> >>> necessarily make committers' lives easier.
> >>>
> >>> Thanks,
> >>> Om
> >>>
> >>>
> >>>> ________________________________________
> >>>> Von: Christofer Dutz <ch...@c-ware.de>
> >>>> Gesendet: Montag, 28. Juli 2014 11:43
> >>>> An: dev@flex.apache.org
> >>>> Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex
> >>>>
> >>>> Yeah, but if the Apache Git infrastructure doesn't support it, we can
> >>>> vote as much as we like, it won't change anything at all ;-)
> >>>>
> >>>> I have seen some projects (Apache Camel) utilize a workflow where
> >>>> someone clones the Projects Github repo and issues normal pull
> >>>>requests to
> >>>> that.
> >>>> From then on some comitter in the project has to manually pull the
> >>>> changes, apply them to the codebase and push them to the Apache repo
> >>>>after
> >>>> which the changes get pushed to Github. After that the initiator has
> >>>>to
> >>>> manaually delete the pull-request as we don't have any access to the
> >>>>Apache
> >>>> GitHub account. So it's not really automatic. And discussions about
> >>>> pull-requests tend to be held in Github and therefore are not
> >>>>archived by
> >>>> Apache (Which they should especially as the Pull Requests have to be
> >>>> deleted after they have been applied). I guess the "not having access
> >>>>to
> >>>> the github account hosting our Flex projects" is the main problem
> >>>>here. So
> >>>> we can't utilize the normal Github workflow. To me it looks as if
> >>>>there is
> >>>> no real benefit in contrast to the "Add patch to Issue", but there are
> >>>> drawbacks (Loosing discussion after deleting PullRequest).
> >>>>
> >>>> Chris
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> ________________________________________
> >>>> Von: João Fernandes <jo...@gmail.com>
> >>>> Gesendet: Montag, 28. Juli 2014 10:54
> >>>> An: dev@flex.apache.org
> >>>> Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
> >>>>
> >>>> Clearly a must have feature!
> >>>>
> >>>>
> >>>> On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com>
> >>>>wrote:
> >>>>
> >>>> > The INFRA team has started supporting [1] pull requests from github.
> >>>> If no
> >>>> > one has objections, I will open a ticket with INFRA to enable this
> >>>> feature
> >>>> > for Apache Flex. In particular, these are the benefits we get from
> >>>> opting
> >>>> > in for the tighter GitHub integration
> >>>> >
> >>>> > - Any Pull Request that gets opened, closed, reopened or
> >>>>commented
> >>>> on
> >>>> > now gets recorded on the project's mailing list
> >>>> > - If a project has a JIRA instance, any PRs or comments on PRs
> >>>>that
> >>>> > include a JIRA ticket ID will trigger an update on that specific
> >>>> ticket
> >>>> > - Replying to a GitHub comment on the dev@ mailing list will
> >>>> trigger a
> >>>> > comment being placed on GitHub (yes, it works both ways!)
> >>>> > - GitHub activity can now be relayed to IRC channels on the
> >>>>Freenode
> >>>> > network.
> >>>> >
> >>>> > This means that we can actually accept pull requests from GitHub
> >>>>going
> >>>> > forward.
> >>>> >
> >>>> > Thanks,
> >>>> > Om
> >>>> >
> >>>> > [1]
> >>>> >
> >>>> >
> >>>>
> >>>>
> https://blogs.apache.org/infra/entry/improved_integration_between_apach
> >>>>e_and
> >>>> >
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> João Fernandes
> >>>>
> >>>
> >>>
> >>
>
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Alex Harui <ah...@adobe.com>.
Odd, it took almost an hour for the robot to respond. It should be in
place, so give it a try.
-Alex
On 9/3/14 3:11 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
>I just got word from INFRA that the hooks have been deployed.
>
>Alex, can you please subscribe asfbot@urd.zones.apache.org to the dev@
>mailing list so that the "reply-to" feature enabled?
>
>Once that is done, we can start testing the workflow.
>
>Thanks,
>Om
>
>
>On Fri, Aug 1, 2014 at 11:44 AM, OmPrakash Muppirala
><bi...@gmail.com>
>wrote:
>
>> I have created a JIRA ticket for Infra for this integration [1] I will
>> send an update when this gets done.
>>
>> Thanks,
>> Om
>>
>> [1] https://issues.apache.org/jira/browse/INFRA-8140
>>
>>
>> On Mon, Jul 28, 2014 at 9:52 AM, OmPrakash Muppirala
>><bigosmallm@gmail.com
>> > wrote:
>>
>>> On Mon, Jul 28, 2014 at 2:46 AM, Christofer Dutz <
>>> christofer.dutz@c-ware.de> wrote:
>>>
>>>> Gee .. why didn't I get the original post ...
>>>>
>>>> so if the comment tracking is handled, I'm fine with that ... but
>>>>still
>>>> it sounds as if the workflow is still not smooth. As far as I know
>>>>you have
>>>> to have access to the account that recieves the pull request in order
>>>>to
>>>> apply it. If you don't you have to manually pull the changes, apply
>>>>them
>>>> youself and the initiating user hast to manually delete them ... or
>>>>has
>>>> Infra put any work into this?
>>>>
>>>> Chris
>>>>
>>>>
>>> Yes, the workflow would be like this:
>>>
>>> 1. A non-committer forks the flex-sdk (or other repos) at
>>> https://github.com/apache/flex-sdk
>>> 2. They make some changes and generate a Pull Request (PR)
>>> 3. The PR notification is forwarded to dev@flex.apache.org
>>> 4. Folks can comment on/review the PR by replying to thread
>>> 5. The comments are forwarded to the Github PR page
>>> 6. An Apache Flex committer gets a patch version of the PR and
>>> integrates it into the flex-sdk repo on ASF git.
>>> 7. This gets merged into github.com/apache/flex-sdk
>>> 8. The committer then responds to the thread on dev@flex.apache.org
>>> asking the creator of the PR to close it.
>>>
>>> This process would make for better community involvement and not
>>> necessarily make committers' lives easier.
>>>
>>> Thanks,
>>> Om
>>>
>>>
>>>> ________________________________________
>>>> Von: Christofer Dutz <ch...@c-ware.de>
>>>> Gesendet: Montag, 28. Juli 2014 11:43
>>>> An: dev@flex.apache.org
>>>> Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex
>>>>
>>>> Yeah, but if the Apache Git infrastructure doesn't support it, we can
>>>> vote as much as we like, it won't change anything at all ;-)
>>>>
>>>> I have seen some projects (Apache Camel) utilize a workflow where
>>>> someone clones the Projects Github repo and issues normal pull
>>>>requests to
>>>> that.
>>>> From then on some comitter in the project has to manually pull the
>>>> changes, apply them to the codebase and push them to the Apache repo
>>>>after
>>>> which the changes get pushed to Github. After that the initiator has
>>>>to
>>>> manaually delete the pull-request as we don't have any access to the
>>>>Apache
>>>> GitHub account. So it's not really automatic. And discussions about
>>>> pull-requests tend to be held in Github and therefore are not
>>>>archived by
>>>> Apache (Which they should especially as the Pull Requests have to be
>>>> deleted after they have been applied). I guess the "not having access
>>>>to
>>>> the github account hosting our Flex projects" is the main problem
>>>>here. So
>>>> we can't utilize the normal Github workflow. To me it looks as if
>>>>there is
>>>> no real benefit in contrast to the "Add patch to Issue", but there are
>>>> drawbacks (Loosing discussion after deleting PullRequest).
>>>>
>>>> Chris
>>>>
>>>>
>>>>
>>>>
>>>> ________________________________________
>>>> Von: João Fernandes <jo...@gmail.com>
>>>> Gesendet: Montag, 28. Juli 2014 10:54
>>>> An: dev@flex.apache.org
>>>> Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
>>>>
>>>> Clearly a must have feature!
>>>>
>>>>
>>>> On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com>
>>>>wrote:
>>>>
>>>> > The INFRA team has started supporting [1] pull requests from github.
>>>> If no
>>>> > one has objections, I will open a ticket with INFRA to enable this
>>>> feature
>>>> > for Apache Flex. In particular, these are the benefits we get from
>>>> opting
>>>> > in for the tighter GitHub integration
>>>> >
>>>> > - Any Pull Request that gets opened, closed, reopened or
>>>>commented
>>>> on
>>>> > now gets recorded on the project's mailing list
>>>> > - If a project has a JIRA instance, any PRs or comments on PRs
>>>>that
>>>> > include a JIRA ticket ID will trigger an update on that specific
>>>> ticket
>>>> > - Replying to a GitHub comment on the dev@ mailing list will
>>>> trigger a
>>>> > comment being placed on GitHub (yes, it works both ways!)
>>>> > - GitHub activity can now be relayed to IRC channels on the
>>>>Freenode
>>>> > network.
>>>> >
>>>> > This means that we can actually accept pull requests from GitHub
>>>>going
>>>> > forward.
>>>> >
>>>> > Thanks,
>>>> > Om
>>>> >
>>>> > [1]
>>>> >
>>>> >
>>>>
>>>>https://blogs.apache.org/infra/entry/improved_integration_between_apach
>>>>e_and
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> João Fernandes
>>>>
>>>
>>>
>>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I just got word from INFRA that the hooks have been deployed.
Alex, can you please subscribe asfbot@urd.zones.apache.org to the dev@
mailing list so that the "reply-to" feature enabled?
Once that is done, we can start testing the workflow.
Thanks,
Om
On Fri, Aug 1, 2014 at 11:44 AM, OmPrakash Muppirala <bi...@gmail.com>
wrote:
> I have created a JIRA ticket for Infra for this integration [1] I will
> send an update when this gets done.
>
> Thanks,
> Om
>
> [1] https://issues.apache.org/jira/browse/INFRA-8140
>
>
> On Mon, Jul 28, 2014 at 9:52 AM, OmPrakash Muppirala <bigosmallm@gmail.com
> > wrote:
>
>> On Mon, Jul 28, 2014 at 2:46 AM, Christofer Dutz <
>> christofer.dutz@c-ware.de> wrote:
>>
>>> Gee .. why didn't I get the original post ...
>>>
>>> so if the comment tracking is handled, I'm fine with that ... but still
>>> it sounds as if the workflow is still not smooth. As far as I know you have
>>> to have access to the account that recieves the pull request in order to
>>> apply it. If you don't you have to manually pull the changes, apply them
>>> youself and the initiating user hast to manually delete them ... or has
>>> Infra put any work into this?
>>>
>>> Chris
>>>
>>>
>> Yes, the workflow would be like this:
>>
>> 1. A non-committer forks the flex-sdk (or other repos) at
>> https://github.com/apache/flex-sdk
>> 2. They make some changes and generate a Pull Request (PR)
>> 3. The PR notification is forwarded to dev@flex.apache.org
>> 4. Folks can comment on/review the PR by replying to thread
>> 5. The comments are forwarded to the Github PR page
>> 6. An Apache Flex committer gets a patch version of the PR and
>> integrates it into the flex-sdk repo on ASF git.
>> 7. This gets merged into github.com/apache/flex-sdk
>> 8. The committer then responds to the thread on dev@flex.apache.org
>> asking the creator of the PR to close it.
>>
>> This process would make for better community involvement and not
>> necessarily make committers' lives easier.
>>
>> Thanks,
>> Om
>>
>>
>>> ________________________________________
>>> Von: Christofer Dutz <ch...@c-ware.de>
>>> Gesendet: Montag, 28. Juli 2014 11:43
>>> An: dev@flex.apache.org
>>> Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex
>>>
>>> Yeah, but if the Apache Git infrastructure doesn't support it, we can
>>> vote as much as we like, it won't change anything at all ;-)
>>>
>>> I have seen some projects (Apache Camel) utilize a workflow where
>>> someone clones the Projects Github repo and issues normal pull requests to
>>> that.
>>> From then on some comitter in the project has to manually pull the
>>> changes, apply them to the codebase and push them to the Apache repo after
>>> which the changes get pushed to Github. After that the initiator has to
>>> manaually delete the pull-request as we don't have any access to the Apache
>>> GitHub account. So it's not really automatic. And discussions about
>>> pull-requests tend to be held in Github and therefore are not archived by
>>> Apache (Which they should especially as the Pull Requests have to be
>>> deleted after they have been applied). I guess the "not having access to
>>> the github account hosting our Flex projects" is the main problem here. So
>>> we can't utilize the normal Github workflow. To me it looks as if there is
>>> no real benefit in contrast to the "Add patch to Issue", but there are
>>> drawbacks (Loosing discussion after deleting PullRequest).
>>>
>>> Chris
>>>
>>>
>>>
>>>
>>> ________________________________________
>>> Von: João Fernandes <jo...@gmail.com>
>>> Gesendet: Montag, 28. Juli 2014 10:54
>>> An: dev@flex.apache.org
>>> Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
>>>
>>> Clearly a must have feature!
>>>
>>>
>>> On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com> wrote:
>>>
>>> > The INFRA team has started supporting [1] pull requests from github.
>>> If no
>>> > one has objections, I will open a ticket with INFRA to enable this
>>> feature
>>> > for Apache Flex. In particular, these are the benefits we get from
>>> opting
>>> > in for the tighter GitHub integration
>>> >
>>> > - Any Pull Request that gets opened, closed, reopened or commented
>>> on
>>> > now gets recorded on the project's mailing list
>>> > - If a project has a JIRA instance, any PRs or comments on PRs that
>>> > include a JIRA ticket ID will trigger an update on that specific
>>> ticket
>>> > - Replying to a GitHub comment on the dev@ mailing list will
>>> trigger a
>>> > comment being placed on GitHub (yes, it works both ways!)
>>> > - GitHub activity can now be relayed to IRC channels on the Freenode
>>> > network.
>>> >
>>> > This means that we can actually accept pull requests from GitHub going
>>> > forward.
>>> >
>>> > Thanks,
>>> > Om
>>> >
>>> > [1]
>>> >
>>> >
>>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>>> >
>>>
>>>
>>>
>>> --
>>>
>>> João Fernandes
>>>
>>
>>
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I have created a JIRA ticket for Infra for this integration [1] I will
send an update when this gets done.
Thanks,
Om
[1] https://issues.apache.org/jira/browse/INFRA-8140
On Mon, Jul 28, 2014 at 9:52 AM, OmPrakash Muppirala <bi...@gmail.com>
wrote:
> On Mon, Jul 28, 2014 at 2:46 AM, Christofer Dutz <
> christofer.dutz@c-ware.de> wrote:
>
>> Gee .. why didn't I get the original post ...
>>
>> so if the comment tracking is handled, I'm fine with that ... but still
>> it sounds as if the workflow is still not smooth. As far as I know you have
>> to have access to the account that recieves the pull request in order to
>> apply it. If you don't you have to manually pull the changes, apply them
>> youself and the initiating user hast to manually delete them ... or has
>> Infra put any work into this?
>>
>> Chris
>>
>>
> Yes, the workflow would be like this:
>
> 1. A non-committer forks the flex-sdk (or other repos) at
> https://github.com/apache/flex-sdk
> 2. They make some changes and generate a Pull Request (PR)
> 3. The PR notification is forwarded to dev@flex.apache.org
> 4. Folks can comment on/review the PR by replying to thread
> 5. The comments are forwarded to the Github PR page
> 6. An Apache Flex committer gets a patch version of the PR and integrates
> it into the flex-sdk repo on ASF git.
> 7. This gets merged into github.com/apache/flex-sdk
> 8. The committer then responds to the thread on dev@flex.apache.org
> asking the creator of the PR to close it.
>
> This process would make for better community involvement and not
> necessarily make committers' lives easier.
>
> Thanks,
> Om
>
>
>> ________________________________________
>> Von: Christofer Dutz <ch...@c-ware.de>
>> Gesendet: Montag, 28. Juli 2014 11:43
>> An: dev@flex.apache.org
>> Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex
>>
>> Yeah, but if the Apache Git infrastructure doesn't support it, we can
>> vote as much as we like, it won't change anything at all ;-)
>>
>> I have seen some projects (Apache Camel) utilize a workflow where someone
>> clones the Projects Github repo and issues normal pull requests to that.
>> From then on some comitter in the project has to manually pull the
>> changes, apply them to the codebase and push them to the Apache repo after
>> which the changes get pushed to Github. After that the initiator has to
>> manaually delete the pull-request as we don't have any access to the Apache
>> GitHub account. So it's not really automatic. And discussions about
>> pull-requests tend to be held in Github and therefore are not archived by
>> Apache (Which they should especially as the Pull Requests have to be
>> deleted after they have been applied). I guess the "not having access to
>> the github account hosting our Flex projects" is the main problem here. So
>> we can't utilize the normal Github workflow. To me it looks as if there is
>> no real benefit in contrast to the "Add patch to Issue", but there are
>> drawbacks (Loosing discussion after deleting PullRequest).
>>
>> Chris
>>
>>
>>
>>
>> ________________________________________
>> Von: João Fernandes <jo...@gmail.com>
>> Gesendet: Montag, 28. Juli 2014 10:54
>> An: dev@flex.apache.org
>> Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
>>
>> Clearly a must have feature!
>>
>>
>> On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com> wrote:
>>
>> > The INFRA team has started supporting [1] pull requests from github.
>> If no
>> > one has objections, I will open a ticket with INFRA to enable this
>> feature
>> > for Apache Flex. In particular, these are the benefits we get from
>> opting
>> > in for the tighter GitHub integration
>> >
>> > - Any Pull Request that gets opened, closed, reopened or commented on
>> > now gets recorded on the project's mailing list
>> > - If a project has a JIRA instance, any PRs or comments on PRs that
>> > include a JIRA ticket ID will trigger an update on that specific
>> ticket
>> > - Replying to a GitHub comment on the dev@ mailing list will
>> trigger a
>> > comment being placed on GitHub (yes, it works both ways!)
>> > - GitHub activity can now be relayed to IRC channels on the Freenode
>> > network.
>> >
>> > This means that we can actually accept pull requests from GitHub going
>> > forward.
>> >
>> > Thanks,
>> > Om
>> >
>> > [1]
>> >
>> >
>> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>> >
>>
>>
>>
>> --
>>
>> João Fernandes
>>
>
>
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Mon, Jul 28, 2014 at 2:46 AM, Christofer Dutz <ch...@c-ware.de>
wrote:
> Gee .. why didn't I get the original post ...
>
> so if the comment tracking is handled, I'm fine with that ... but still it
> sounds as if the workflow is still not smooth. As far as I know you have to
> have access to the account that recieves the pull request in order to apply
> it. If you don't you have to manually pull the changes, apply them youself
> and the initiating user hast to manually delete them ... or has Infra put
> any work into this?
>
> Chris
>
>
Yes, the workflow would be like this:
1. A non-committer forks the flex-sdk (or other repos) at
https://github.com/apache/flex-sdk
2. They make some changes and generate a Pull Request (PR)
3. The PR notification is forwarded to dev@flex.apache.org
4. Folks can comment on/review the PR by replying to thread
5. The comments are forwarded to the Github PR page
6. An Apache Flex committer gets a patch version of the PR and integrates
it into the flex-sdk repo on ASF git.
7. This gets merged into github.com/apache/flex-sdk
8. The committer then responds to the thread on dev@flex.apache.org asking
the creator of the PR to close it.
This process would make for better community involvement and not
necessarily make committers' lives easier.
Thanks,
Om
> ________________________________________
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Montag, 28. Juli 2014 11:43
> An: dev@flex.apache.org
> Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex
>
> Yeah, but if the Apache Git infrastructure doesn't support it, we can vote
> as much as we like, it won't change anything at all ;-)
>
> I have seen some projects (Apache Camel) utilize a workflow where someone
> clones the Projects Github repo and issues normal pull requests to that.
> From then on some comitter in the project has to manually pull the
> changes, apply them to the codebase and push them to the Apache repo after
> which the changes get pushed to Github. After that the initiator has to
> manaually delete the pull-request as we don't have any access to the Apache
> GitHub account. So it's not really automatic. And discussions about
> pull-requests tend to be held in Github and therefore are not archived by
> Apache (Which they should especially as the Pull Requests have to be
> deleted after they have been applied). I guess the "not having access to
> the github account hosting our Flex projects" is the main problem here. So
> we can't utilize the normal Github workflow. To me it looks as if there is
> no real benefit in contrast to the "Add patch to Issue", but there are
> drawbacks (Loosing discussion after deleting PullRequest).
>
> Chris
>
>
>
>
> ________________________________________
> Von: João Fernandes <jo...@gmail.com>
> Gesendet: Montag, 28. Juli 2014 10:54
> An: dev@flex.apache.org
> Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
>
> Clearly a must have feature!
>
>
> On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com> wrote:
>
> > The INFRA team has started supporting [1] pull requests from github. If
> no
> > one has objections, I will open a ticket with INFRA to enable this
> feature
> > for Apache Flex. In particular, these are the benefits we get from
> opting
> > in for the tighter GitHub integration
> >
> > - Any Pull Request that gets opened, closed, reopened or commented on
> > now gets recorded on the project's mailing list
> > - If a project has a JIRA instance, any PRs or comments on PRs that
> > include a JIRA ticket ID will trigger an update on that specific
> ticket
> > - Replying to a GitHub comment on the dev@ mailing list will trigger
> a
> > comment being placed on GitHub (yes, it works both ways!)
> > - GitHub activity can now be relayed to IRC channels on the Freenode
> > network.
> >
> > This means that we can actually accept pull requests from GitHub going
> > forward.
> >
> > Thanks,
> > Om
> >
> > [1]
> >
> >
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
> >
>
>
>
> --
>
> João Fernandes
>
AW: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Christofer Dutz <ch...@c-ware.de>.
Gee .. why didn't I get the original post ...
so if the comment tracking is handled, I'm fine with that ... but still it sounds as if the workflow is still not smooth. As far as I know you have to have access to the account that recieves the pull request in order to apply it. If you don't you have to manually pull the changes, apply them youself and the initiating user hast to manually delete them ... or has Infra put any work into this?
Chris
________________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Montag, 28. Juli 2014 11:43
An: dev@flex.apache.org
Betreff: AW: [LAZY] Enabling Github pull requests in Apache Flex
Yeah, but if the Apache Git infrastructure doesn't support it, we can vote as much as we like, it won't change anything at all ;-)
I have seen some projects (Apache Camel) utilize a workflow where someone clones the Projects Github repo and issues normal pull requests to that.
>From then on some comitter in the project has to manually pull the changes, apply them to the codebase and push them to the Apache repo after which the changes get pushed to Github. After that the initiator has to manaually delete the pull-request as we don't have any access to the Apache GitHub account. So it's not really automatic. And discussions about pull-requests tend to be held in Github and therefore are not archived by Apache (Which they should especially as the Pull Requests have to be deleted after they have been applied). I guess the "not having access to the github account hosting our Flex projects" is the main problem here. So we can't utilize the normal Github workflow. To me it looks as if there is no real benefit in contrast to the "Add patch to Issue", but there are drawbacks (Loosing discussion after deleting PullRequest).
Chris
________________________________________
Von: João Fernandes <jo...@gmail.com>
Gesendet: Montag, 28. Juli 2014 10:54
An: dev@flex.apache.org
Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
Clearly a must have feature!
On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com> wrote:
> The INFRA team has started supporting [1] pull requests from github. If no
> one has objections, I will open a ticket with INFRA to enable this feature
> for Apache Flex. In particular, these are the benefits we get from opting
> in for the tighter GitHub integration
>
> - Any Pull Request that gets opened, closed, reopened or commented on
> now gets recorded on the project's mailing list
> - If a project has a JIRA instance, any PRs or comments on PRs that
> include a JIRA ticket ID will trigger an update on that specific ticket
> - Replying to a GitHub comment on the dev@ mailing list will trigger a
> comment being placed on GitHub (yes, it works both ways!)
> - GitHub activity can now be relayed to IRC channels on the Freenode
> network.
>
> This means that we can actually accept pull requests from GitHub going
> forward.
>
> Thanks,
> Om
>
> [1]
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
--
João Fernandes
RE: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Kessler CTR Mark J <ma...@usmc.mil>.
I've seen a few different test for github pull requests and comments. One of which is in the Infrastructure mailing list.
-Mark
AW: [LAZY] Enabling Github pull requests in Apache Flex
Posted by Christofer Dutz <ch...@c-ware.de>.
Yeah, but if the Apache Git infrastructure doesn't support it, we can vote as much as we like, it won't change anything at all ;-)
I have seen some projects (Apache Camel) utilize a workflow where someone clones the Projects Github repo and issues normal pull requests to that.
>From then on some comitter in the project has to manually pull the changes, apply them to the codebase and push them to the Apache repo after which the changes get pushed to Github. After that the initiator has to manaually delete the pull-request as we don't have any access to the Apache GitHub account. So it's not really automatic. And discussions about pull-requests tend to be held in Github and therefore are not archived by Apache (Which they should especially as the Pull Requests have to be deleted after they have been applied). I guess the "not having access to the github account hosting our Flex projects" is the main problem here. So we can't utilize the normal Github workflow. To me it looks as if there is no real benefit in contrast to the "Add patch to Issue", but there are drawbacks (Loosing discussion after deleting PullRequest).
Chris
________________________________________
Von: João Fernandes <jo...@gmail.com>
Gesendet: Montag, 28. Juli 2014 10:54
An: dev@flex.apache.org
Betreff: Re: [LAZY] Enabling Github pull requests in Apache Flex
Clearly a must have feature!
On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com> wrote:
> The INFRA team has started supporting [1] pull requests from github. If no
> one has objections, I will open a ticket with INFRA to enable this feature
> for Apache Flex. In particular, these are the benefits we get from opting
> in for the tighter GitHub integration
>
> - Any Pull Request that gets opened, closed, reopened or commented on
> now gets recorded on the project's mailing list
> - If a project has a JIRA instance, any PRs or comments on PRs that
> include a JIRA ticket ID will trigger an update on that specific ticket
> - Replying to a GitHub comment on the dev@ mailing list will trigger a
> comment being placed on GitHub (yes, it works both ways!)
> - GitHub activity can now be relayed to IRC channels on the Freenode
> network.
>
> This means that we can actually accept pull requests from GitHub going
> forward.
>
> Thanks,
> Om
>
> [1]
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
--
João Fernandes
Re: [LAZY] Enabling Github pull requests in Apache Flex
Posted by João Fernandes <jo...@gmail.com>.
Clearly a must have feature!
On 25 July 2014 01:34, OmPrakash Muppirala <bi...@gmail.com> wrote:
> The INFRA team has started supporting [1] pull requests from github. If no
> one has objections, I will open a ticket with INFRA to enable this feature
> for Apache Flex. In particular, these are the benefits we get from opting
> in for the tighter GitHub integration
>
> - Any Pull Request that gets opened, closed, reopened or commented on
> now gets recorded on the project's mailing list
> - If a project has a JIRA instance, any PRs or comments on PRs that
> include a JIRA ticket ID will trigger an update on that specific ticket
> - Replying to a GitHub comment on the dev@ mailing list will trigger a
> comment being placed on GitHub (yes, it works both ways!)
> - GitHub activity can now be relayed to IRC channels on the Freenode
> network.
>
> This means that we can actually accept pull requests from GitHub going
> forward.
>
> Thanks,
> Om
>
> [1]
>
> https://blogs.apache.org/infra/entry/improved_integration_between_apache_and
>
--
João Fernandes