You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 08:32:36 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4047: Look for active templates for VR deployment
ravening opened a new pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047
## Description
If the template from which VR is created got deleted, the state
is set to inactive and removed to null.
Since the template is already deleted, the VR can't be created
using this template again.
If someone restarts network with cleanup then it will try to
deploy the vr from the old non existing template again.
So search only for active template which are not yet deleted.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
1. Create a network and this will in turn create VR's
2. Note down the template from which the VR was created
3. Delete that template
4. Now restart the network with cleanup option
5. The new router deployment should be successful using another active template from the platform
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783256560
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784397704
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-781930238
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-665551768
> as per your description @ravening, "If the template from which VR is created got deleted, the state
> is set to inactive and removed to null.", it seems the 'real' bug is that removed is set to null whilst it should be set to the time of deletion. Your code will work, but is it not hiding this 'real' problem? Being very defensive, we might want to address both issues.
I will see if I can reproduce the issue to check which part of the code is setting it to null instead of removed timestamp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-727925713
ok tnx @nvazquez . As said I do have my doubt as I think we might be hiding the issue, but will not đź‘Ž .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783360325
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-781989008
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654670858
Packaging result: ✔centos7 ✔debian. JID-1542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-779049372
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783255803
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] svenvogel commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-621737795
Hi @ravening small question. 🙏 how do you delete the template? api or ui?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-781941730
Packaging result: âś–centos7 âś–centos8 âś–debian. JID-2746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783909885
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-622283301
> Hi @ravening small question. 🙏 how do you delete the template? api or ui?
Hello @svenvogel , its mostly through UI but can be done through api as well I guess but I have not tried using api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654650530
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-727906944
I think the fix makes sense as it is now. I don't know the reason why we set the template to Inactive but not removed instead of removing it (timestamp on the removed column) as we normally do with other entities, probably it is not a bug but the expected behaviour by design
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-781929764
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-781988557
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-782040382
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-712787104
@nvazquez do you have an opinion as well on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654891499
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784397281
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-779048436
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-779078378
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783907382
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-656889979
<b>Trillian test result (tid-2054)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44443 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t2054-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_deploy_kubernetes_ha_cluster | `Error` | 3612.81 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.52 | test_kubernetes_clusters.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 306.26 | test_vpc_redundant.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784356125
<b>Trillian test result (tid-3596)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40164 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t3596-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement_nestedplugin.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 79 look OK, 7 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 34.14 | test_primary_storage.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 44.48 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3612.32 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 112.33 | test_kubernetes_clusters.py
test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
test_01_deploy_vm_on_specific_host | `Error` | 20.99 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.43 | test_vm_deployment_planner.py
test_11_migrate_vm | `Error` | 4.39 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.83 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654892141
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-783302932
Packaging result: âś–centos7 âś–centos8 âś–debian. JID-2779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654651062
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-665506324
as per your description @ravening, "If the template from which VR is created got deleted, the state
is set to inactive and removed to null.", it seems the 'real' bug is that removed is set to null whilst it should be set to the time of deletion. Your code will work, but is it not hiding this 'real' problem? Being very defensive, we might want to address both issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4047:
URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-784728199
<b>Trillian test result (tid-3609)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32372 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4047-t3609-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org