You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/02 16:26:31 UTC
[GitHub] [spark] wangyum opened a new pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
wangyum opened a new pull request #30992:
URL: https://github.com/apache/spark/pull/30992
### What changes were proposed in this pull request?
This pr add support push down Limit through Sort.
### Why are the changes needed?
Improve query performance.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test and benchmark test:
```scala
spark.range(500000000).write.saveAsTable("t1")
spark.sql("select * from t1 order by id limit 2").show
```
Before this pr | After this pr
-- | --
 | 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #30992:
URL: https://github.com/apache/spark/pull/30992
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753505054
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133594/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753512628
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38183/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753509209
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38183/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753512628
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38183/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753495045
**[Test build #133594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133594/testReport)** for PR 30992 at commit [`e82ff4c`](https://github.com/apache/spark/commit/e82ff4c049f1d69d0368ec3adedb1e737c182a82).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753501424
**[Test build #133594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133594/testReport)** for PR 30992 at commit [`e82ff4c`](https://github.com/apache/spark/commit/e82ff4c049f1d69d0368ec3adedb1e737c182a82).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753505054
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133594/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753495045
**[Test build #133594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133594/testReport)** for PR 30992 at commit [`e82ff4c`](https://github.com/apache/spark/commit/e82ff4c049f1d69d0368ec3adedb1e737c182a82).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753550357
Sorry, close it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753504574
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38183/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #30992: [SPARK-33960][SQL] Push down Limit through Sort
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #30992:
URL: https://github.com/apache/spark/pull/30992#issuecomment-753526631
Doesn't this change the output?
In the Range example the values are in order, but what if they are not?
For values 1, 3, 2 query `Limit 2 -> Sort` would sort it before and return 1, 2. With this change it would limit before sorting and return 1, 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org