[GitHub] [superset] ofekisr opened a new pull request #16448: Refactor/sql json view

[GitBox <gi...@apache.org>]

ofekisr opened a new pull request #16448:
URL: https://github.com/apache/superset/pull/16448


   SUMMARY
   The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
   This is the second PR in the sequence of future PRs ([previous PR](https://github.com/apache/superset/pull/16441)) try to solve it by refactoring the code.
   The PR focus of encapsulate and separate the getting and checking existing query concern into ad hoc methods. 
   
   
   TESTING INSTRUCTIONS
   there are no logic changes so it implies on the current tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ofekisr closed pull request #16448: Refactor/sql json view

[GitBox <gi...@apache.org>]

ofekisr closed pull request #16448:
URL: https://github.com/apache/superset/pull/16448


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org