You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-user@lucene.apache.org by zhenyuan wei <ti...@gmail.com> on 2019/04/16 03:58:15 UTC
Mistake assert tips in FST builder ?
Hi,
With current newest version, 9.0.0-snapshot,In
Builder.UnCompileNode.addArc() function,
found this line:
assert numArcs == 0 || label > arcs[numArcs-1].label: "arc[-1].label="
+ arcs[numArcs-1].label + " new label=" + label + " numArcs=" +
numArcs;
Maybe assert tips is :
assert numArcs == 0 || label > arcs[numArcs-1].label:
"arc[numArc-1].label=" + arcs[numArcs-1].label + " new label=" + label
+ " numArcs=" + numArcs;
Is it a personal tips code style? or small mistake?
Just curious about it.
Re: Mistake assert tips in FST builder ?
Posted by Tomás Fernández Löbbe <to...@gmail.com>.
The Lucene list is probably better for this question. I'd try
java-user@lucene.apache.org
On Mon, Apr 15, 2019 at 9:04 PM zhenyuan wei <ti...@gmail.com> wrote:
> Hi,
> With current newest version, 9.0.0-snapshot,In
> Builder.UnCompileNode.addArc() function,
> found this line:
>
> assert numArcs == 0 || label > arcs[numArcs-1].label: "arc[-1].label="
> + arcs[numArcs-1].label + " new label=" + label + " numArcs=" +
> numArcs;
>
> Maybe assert tips is :
>
> assert numArcs == 0 || label > arcs[numArcs-1].label:
> "arc[numArc-1].label=" + arcs[numArcs-1].label + " new label=" + label
> + " numArcs=" + numArcs;
>
> Is it a personal tips code style? or small mistake?
>
> Just curious about it.
>
Re: Mistake assert tips in FST builder ?
Posted by Michael McCandless <lu...@mikemccandless.com>.
Hello,
Indeed, you cosmetic fix looks great -- I'll push that change. Thanks for
noticing and raising!
Mike McCandless
http://blog.mikemccandless.com
On Tue, Apr 16, 2019 at 12:04 AM zhenyuan wei <ti...@gmail.com> wrote:
> Hi,
> With current newest version, 9.0.0-snapshot,In
> Builder.UnCompileNode.addArc() function,
> found this line:
>
> assert numArcs == 0 || label > arcs[numArcs-1].label: "arc[-1].label="
> + arcs[numArcs-1].label + " new label=" + label + " numArcs=" +
> numArcs;
>
> Maybe assert tips is :
>
> assert numArcs == 0 || label > arcs[numArcs-1].label:
> "arc[numArc-1].label=" + arcs[numArcs-1].label + " new label=" + label
> + " numArcs=" + numArcs;
>
> Is it a personal tips code style? or small mistake?
>
> Just curious about it.
>