You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by rj...@apache.org on 2011/07/11 18:51:55 UTC
svn commit: r1145238 - in /tomcat/trunk:
java/org/apache/catalina/valves/ExtendedAccessLogValve.java
webapps/docs/changelog.xml
Author: rjung
Date: Mon Jul 11 16:51:54 2011
New Revision: 1145238
URL: http://svn.apache.org/viewvc?rev=1145238&view=rev
Log:
Always use en_US as locale for timestamps in
ExtendedAccessLogValve.
The format is specified in
http://www.w3.org/TR/WD-logfile.html
and states that the supported timestamps
"yyyy-MM-dd" and "HH:mm:ss" are defined with
ascii digits and GMT.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1145238&r1=1145237&r2=1145238&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java Mon Jul 11 16:51:54 2011
@@ -28,6 +28,7 @@ import java.util.ArrayList;
import java.util.Date;
import java.util.Iterator;
import java.util.List;
+import java.util.Locale;
import java.util.TimeZone;
import javax.servlet.http.Cookie;
@@ -875,7 +876,7 @@ public class ExtendedAccessLogValve exte
private String currentTimestampString;
ElementTimestampStruct(String format) {
- currentTimestampFormat = new SimpleDateFormat(format);
+ currentTimestampFormat = new SimpleDateFormat(format, Locale.US);
currentTimestampFormat.setTimeZone(TimeZone.getTimeZone("GMT"));
}
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1145238&r1=1145237&r2=1145238&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jul 11 16:51:54 2011
@@ -88,6 +88,10 @@
<fix>
Log a failure if access log file cannot be opened. (kkolinko)
</fix>
+ <fix>
+ Always use en_US as locale for timestamps in ExtendedAccessLogValve.
+ (rjung)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org