[GitHub] [sling-org-apache-sling-jms] joerghoh commented on a change in pull request #1: Convert XML config to Java-Config

[GitBox <gi...@apache.org>]

joerghoh commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#discussion_r717325485



##########
File path: pom.xml
##########
@@ -241,5 +241,18 @@
             <version>1.10.19</version>
             <scope>test</scope>
         </dependency>
+
+        <dependency>
+            <groupId>org.eclipse.jetty.aggregate</groupId>
+            <artifactId>jetty-all</artifactId>
+            <version>8.1.22.v20160922</version>
+            <scope>provided</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.springframework</groupId>
+            <artifactId>spring-context</artifactId>
+            <version>5.3.9</version>
+            <scope>provided</scope>

Review comment:
       So does this require to have spring-context and jetty-all within the OSGI container running? What kind of additional resource consumption (deployment size, heap) would that mean?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org