[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1632: [CELEBORN-720][BUG] SortBasedShuffleWriter should update peakMemoryUsedBytes and increase PeakExecutionMemory

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1632:
URL: https://github.com/apache/incubator-celeborn/pull/1632#discussion_r1243432805


##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedShuffleWriter.java:
##########
@@ -377,7 +405,7 @@ private void updateMapStatus() {
   @Override
   public Option<MapStatus> stop(boolean success) {
     try {
-      taskContext.taskMetrics().incPeakExecutionMemory(peakMemoryUsedBytes);
+      taskContext.taskMetrics().incPeakExecutionMemory(getPeakMemoryUsedBytes());

Review Comment:
   > The variable `private long peakMemoryUsedBytes = 0;` defined in this class could be deleted then?
   
   No, still need



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org