[incubator-celeborn] branch main updated: [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class

[ch...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 3964861fd [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class
3964861fd is described below

commit 3964861fd7b23096eb83962a22ec308f6207b4e8
Author: Fu Chen <cf...@gmail.com>
AuthorDate: Mon Jul 3 13:40:30 2023 +0800

    [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class
    
    ### What changes were proposed in this pull request?
    
    As title
    
    ### Why are the changes needed?
    
    eliminate comments introduced in https://github.com/apache/incubator-celeborn/pull/1650
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Pass GA
    
    Closes #1672 from cfmcgrady/primary-replica-followup.
    
    Authored-by: Fu Chen <cf...@gmail.com>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../scala/org/apache/celeborn/service/deploy/worker/Controller.scala    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala
index 8ad590160..d6b034924 100644
--- a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala
+++ b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala
@@ -482,7 +482,6 @@ private[deploy] class Controller(
               s"${committedPrimaryIds.size()} committed primary partitions, " +
               s"${emptyFilePrimaryIds.size()} empty primary partitions, " +
               s"${failedPrimaryIds.size()} failed primary partitions, " +
-              // TODO: (remove comment) this should be a bug before
               s"${committedReplicaIds.size()} committed replica partitions, " +
               s"${emptyFileReplicaIds.size()} empty replica partitions, " +
               s"${failedReplicaIds.size()} failed replica partitions.")
@@ -503,7 +502,6 @@ private[deploy] class Controller(
               s"${committedPrimaryIds.size()} committed primary partitions, " +
               s"${emptyFilePrimaryIds.size()} empty primary partitions, " +
               s"${failedPrimaryIds.size()} failed primary partitions, " +
-              // TODO: (remove comment) this should be a bug before
               s"${committedReplicaIds.size()} committed replica partitions, " +
               s"${emptyFileReplicaIds.size()} empty replica partitions, " +
               s"${failedReplicaIds.size()} failed replica partitions.")