You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/04/15 18:36:00 UTC

Review Request 20370: Fix KAFKA-1323: rebase on trunk, unit tests passed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20370/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1323
    https://issues.apache.org/jira/browse/KAFKA-1323


Repository: kafka


Description
-------

Rebase on trunk


Diffs
-----

  core/src/main/scala/kafka/cluster/Partition.scala 6d6b4ab91608162201d2737d784580728193566a 
  core/src/main/scala/kafka/log/LogManager.scala 8ed9b68e763aa14e3ef282eec738fa190eb20132 
  core/src/main/scala/kafka/server/ReplicaManager.scala 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala bbfb01ed486d6625801d99e9f032745a47d855c9 
  core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala a71e48d5ca674875c9dd62466be860f90ce6f1cd 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 53d01aa3e501392672ee6bc7f0e225493383c870 

Diff: https://reviews.apache.org/r/20370/diff/


Testing
-------


Thanks,

Guozhang Wang

Re: Review Request 20370: Fix KAFKA-1323: rebase on trunk, unit tests passed

Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20370/#review40466
-----------------------------------------------------------

Ship it!



core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
<https://reviews.apache.org/r/20370/#comment73491>

    Will remove this on check-in.


- Joel Koshy


On April 15, 2014, 4:36 p.m., Guozhang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20370/
> -----------------------------------------------------------
> 
> (Updated April 15, 2014, 4:36 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1323
>     https://issues.apache.org/jira/browse/KAFKA-1323
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Rebase on trunk
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/cluster/Partition.scala 6d6b4ab91608162201d2737d784580728193566a 
>   core/src/main/scala/kafka/log/LogManager.scala 8ed9b68e763aa14e3ef282eec738fa190eb20132 
>   core/src/main/scala/kafka/server/ReplicaManager.scala 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 
>   core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
>   core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala bbfb01ed486d6625801d99e9f032745a47d855c9 
>   core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala a71e48d5ca674875c9dd62466be860f90ce6f1cd 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 53d01aa3e501392672ee6bc7f0e225493383c870 
> 
> Diff: https://reviews.apache.org/r/20370/diff/
> 
> 
> Testing
> -------
> 
> unit tests
> 
> 
> Thanks,
> 
> Guozhang Wang
> 
>

Re: Review Request 20370: Fix KAFKA-1323: rebase on trunk, unit tests passed

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20370/
-----------------------------------------------------------

(Updated April 15, 2014, 4:36 p.m.)


Review request for kafka.


Bugs: KAFKA-1323
    https://issues.apache.org/jira/browse/KAFKA-1323


Repository: kafka


Description
-------

Rebase on trunk


Diffs
-----

  core/src/main/scala/kafka/cluster/Partition.scala 6d6b4ab91608162201d2737d784580728193566a 
  core/src/main/scala/kafka/log/LogManager.scala 8ed9b68e763aa14e3ef282eec738fa190eb20132 
  core/src/main/scala/kafka/server/ReplicaManager.scala 0f5aaa9888d6c0ca0b073f4742bee14ad72d0484 
  core/src/test/scala/unit/kafka/log/LogManagerTest.scala b4bee33191ebc0b4ab5a5f82fa232cd3bda8fef8 
  core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala bbfb01ed486d6625801d99e9f032745a47d855c9 
  core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala a71e48d5ca674875c9dd62466be860f90ce6f1cd 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 53d01aa3e501392672ee6bc7f0e225493383c870 

Diff: https://reviews.apache.org/r/20370/diff/


Testing (updated)
-------

unit tests


Thanks,

Guozhang Wang