You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/08 16:13:18 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #1500: Backport LUCENE-9350 to branch_8_5
madrob opened a new pull request #1500:
URL: https://github.com/apache/lucene-solr/pull/1500
It may be worthwhile to review this by individual commits instead of all at once. I do not intend to squash these when committing.
I'm most concerned about whether the changes in commit 3363df7 are sufficient - they are enough for API and compilation, but it's not clear if I needed to update some implementations of QueryVisitor to tie all of this together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #1500: Backport LUCENE-9350 to branch_8_5
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1500:
URL: https://github.com/apache/lucene-solr/pull/1500#issuecomment-626003039
> Can we change it to build the automaton directly in FuzzyQuery.visit()
Sure, I dropped the QueryVisitor changes and we do this now.
I think the changes to use a Supplier in FuzzyTermsEnum are still ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] romseygeek commented on pull request #1500: Backport LUCENE-9350 to branch_8_5
Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #1500:
URL: https://github.com/apache/lucene-solr/pull/1500#issuecomment-625942131
I don't think we should backport the changes to QueryVisitor, we shouldn't be breaking APIs in a bugfix release even if it is experimental. Can we change it to build the automaton directly in FuzzyQuery.visit()? It's not ideal, but it's the status quo ante
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob edited a comment on pull request #1500: Backport LUCENE-9350 to branch_8_5
Posted by GitBox <gi...@apache.org>.
madrob edited a comment on pull request #1500:
URL: https://github.com/apache/lucene-solr/pull/1500#issuecomment-626003039
> Can we change it to build the automaton directly in FuzzyQuery.visit()
Sure, I dropped the QueryVisitor changes and we do this now.
I think the changes to use a Supplier in FuzzyTermsEnum are still ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org