You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/11/26 22:35:06 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2827: [COBBLIN-981]Handle backward compatibility issue in HiveSource

sv2000 commented on a change in pull request #2827: [COBBLIN-981]Handle backward compatibility issue in HiveSource
URL: https://github.com/apache/incubator-gobblin/pull/2827#discussion_r351014623
 
 

 ##########
 File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/source/HiveSource.java
 ##########
 @@ -276,6 +279,11 @@ protected void createWorkunitForNonPartitionedTable(HiveDataset hiveDataset, boo
     }
   }
 
+  @Deprecated
+  protected HiveWorkUnit workUnitForTable(HiveDataset hiveDataset) throws IOException {
 
 Review comment:
   Can we just keep the older APIs and get rid of the methods where we pass disableAvroCheck as an argument? Instead, we can just access this property via the source state object. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services