You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2006/02/28 15:42:39 UTC

[jira] Created: (JCR-329) NodeReferencesId.equals() is not symetric

NodeReferencesId.equals() is not symetric
-----------------------------------------

         Key: JCR-329
         URL: http://issues.apache.org/jira/browse/JCR-329
     Project: Jackrabbit
        Type: Improvement
    Versions: 0.9    
    Reporter: Marcel Reutegger
    Priority: Minor
     Fix For: 1.0
 Attachments: NodeReferencesId.patch

NodeReferencesId.equals() is not symetric when equality is tested against a NodeId.

Code example:
UUID uuid = UUID.randomUUID();
NodeId id = new NodeId(uuid);
NodeReferencesId refId = new NodeReferencesId(uuid);
id.equals(refId); // will return true
refId.equals(id); // will return false

NodeReferencesId should be decouled from the ItemId hierarchy. The class NodeReferences already does not extend from NodeState which makes perfectly sense. So, the same should apply to the identifier of NodeReferences.

The attached patch to NodeReferencesId also requires minor changes to some of the persistence managers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (JCR-329) NodeReferencesId.equals() is not symetric

Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-329?page=all ]

Marcel Reutegger updated JCR-329:
---------------------------------

    Attachment: NodeReferencesId.patch

> NodeReferencesId.equals() is not symetric
> -----------------------------------------
>
>          Key: JCR-329
>          URL: http://issues.apache.org/jira/browse/JCR-329
>      Project: Jackrabbit
>         Type: Improvement
>     Versions: 0.9
>     Reporter: Marcel Reutegger
>     Priority: Minor
>      Fix For: 1.0
>  Attachments: NodeReferencesId.patch
>
> NodeReferencesId.equals() is not symetric when equality is tested against a NodeId.
> Code example:
> UUID uuid = UUID.randomUUID();
> NodeId id = new NodeId(uuid);
> NodeReferencesId refId = new NodeReferencesId(uuid);
> id.equals(refId); // will return true
> refId.equals(id); // will return false
> NodeReferencesId should be decouled from the ItemId hierarchy. The class NodeReferences already does not extend from NodeState which makes perfectly sense. So, the same should apply to the identifier of NodeReferences.
> The attached patch to NodeReferencesId also requires minor changes to some of the persistence managers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Assigned: (JCR-329) NodeReferencesId.equals() is not symetric

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-329?page=all ]

Stefan Guggisberg reassigned JCR-329:
-------------------------------------

    Assign To: Stefan Guggisberg

> NodeReferencesId.equals() is not symetric
> -----------------------------------------
>
>          Key: JCR-329
>          URL: http://issues.apache.org/jira/browse/JCR-329
>      Project: Jackrabbit
>         Type: Improvement
>     Versions: 0.9
>     Reporter: Marcel Reutegger
>     Assignee: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.0
>  Attachments: NodeReferencesId.patch
>
> NodeReferencesId.equals() is not symetric when equality is tested against a NodeId.
> Code example:
> UUID uuid = UUID.randomUUID();
> NodeId id = new NodeId(uuid);
> NodeReferencesId refId = new NodeReferencesId(uuid);
> id.equals(refId); // will return true
> refId.equals(id); // will return false
> NodeReferencesId should be decouled from the ItemId hierarchy. The class NodeReferences already does not extend from NodeState which makes perfectly sense. So, the same should apply to the identifier of NodeReferences.
> The attached patch to NodeReferencesId also requires minor changes to some of the persistence managers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (JCR-329) NodeReferencesId.equals() is not symetric

Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JCR-329?page=comments#action_12368121 ] 

Tobias Bocanegra commented on JCR-329:
--------------------------------------

i would perfer:

NodeReferencesId NodeReferences.getId() ;
NodeId NodeReferences.getTargetId();

and NodeReferencedId _not_ extending from NodeId

> NodeReferencesId.equals() is not symetric
> -----------------------------------------
>
>          Key: JCR-329
>          URL: http://issues.apache.org/jira/browse/JCR-329
>      Project: Jackrabbit
>         Type: Improvement
>     Versions: 0.9
>     Reporter: Marcel Reutegger
>     Assignee: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.0
>  Attachments: NodeReferencesId.patch
>
> NodeReferencesId.equals() is not symetric when equality is tested against a NodeId.
> Code example:
> UUID uuid = UUID.randomUUID();
> NodeId id = new NodeId(uuid);
> NodeReferencesId refId = new NodeReferencesId(uuid);
> id.equals(refId); // will return true
> refId.equals(id); // will return false
> NodeReferencesId should be decouled from the ItemId hierarchy. The class NodeReferences already does not extend from NodeState which makes perfectly sense. So, the same should apply to the identifier of NodeReferences.
> The attached patch to NodeReferencesId also requires minor changes to some of the persistence managers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (JCR-329) NodeReferencesId.equals() is not symetric

Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-329?page=all ]
     
Stefan Guggisberg closed JCR-329:
---------------------------------

    Resolution: Fixed

incorporated all suggested changes (svn r382075)

> NodeReferencesId.equals() is not symetric
> -----------------------------------------
>
>          Key: JCR-329
>          URL: http://issues.apache.org/jira/browse/JCR-329
>      Project: Jackrabbit
>         Type: Improvement
>     Versions: 0.9
>     Reporter: Marcel Reutegger
>     Assignee: Stefan Guggisberg
>     Priority: Minor
>      Fix For: 1.0
>  Attachments: NodeReferencesId.patch
>
> NodeReferencesId.equals() is not symetric when equality is tested against a NodeId.
> Code example:
> UUID uuid = UUID.randomUUID();
> NodeId id = new NodeId(uuid);
> NodeReferencesId refId = new NodeReferencesId(uuid);
> id.equals(refId); // will return true
> refId.equals(id); // will return false
> NodeReferencesId should be decouled from the ItemId hierarchy. The class NodeReferences already does not extend from NodeState which makes perfectly sense. So, the same should apply to the identifier of NodeReferences.
> The attached patch to NodeReferencesId also requires minor changes to some of the persistence managers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira