You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kelven Yang <ke...@citrix.com> on 2013/04/16 02:39:17 UTC
Review Request: Improve console access security with 128-bit AES encryption
and securely-randomized key generation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10533/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
Improve console access security with 128-bit AES encryption and securely-randomized key generation
This addresses bug CLOUDSTACK-2039.
Diffs
-----
console-proxy/src/com/cloud/consoleproxy/ConsoleProxyPasswordBasedEncryptor.java 29826f0
server/src/com/cloud/configuration/Config.java 0815a77
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 168ac0e
server/src/com/cloud/server/ManagementServer.java 5c34dee
server/src/com/cloud/server/ManagementServerImpl.java 9cddb77
server/src/com/cloud/servlet/ConsoleProxyPasswordBasedEncryptor.java 2638c8b
server/src/com/cloud/servlet/ConsoleProxyServlet.java c4b9334
Diff: https://reviews.apache.org/r/10533/diff/
Testing
-------
Manually tested
Thanks,
Kelven Yang
Re: Review Request: Improve console access security with 128-bit AES
encryption and securely-randomized key generation
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10533/#review19233
-----------------------------------------------------------
Ship it!
Committed to 4.1:
commit 73ed03baea3f6718f74703b752a61c4314246a69
Author: Kelven Yang <ke...@gmail.com>
Date: Mon Apr 15 16:51:50 2013 -0700
CLOUDSTACK-2039: Improve console access security with 128-bit AES encryption and securely-randomized key generation
- Chip Childers
On April 16, 2013, 12:39 a.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10533/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 12:39 a.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> Improve console access security with 128-bit AES encryption and securely-randomized key generation
>
>
> This addresses bug CLOUDSTACK-2039.
>
>
> Diffs
> -----
>
> console-proxy/src/com/cloud/consoleproxy/ConsoleProxyPasswordBasedEncryptor.java 29826f0
> server/src/com/cloud/configuration/Config.java 0815a77
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 168ac0e
> server/src/com/cloud/server/ManagementServer.java 5c34dee
> server/src/com/cloud/server/ManagementServerImpl.java 9cddb77
> server/src/com/cloud/servlet/ConsoleProxyPasswordBasedEncryptor.java 2638c8b
> server/src/com/cloud/servlet/ConsoleProxyServlet.java c4b9334
>
> Diff: https://reviews.apache.org/r/10533/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Kelven Yang
>
>
Re: Review Request: Improve console access security with 128-bit AES
encryption and securely-randomized key generation
Posted by Prasanna Santhanam <ts...@apache.org>.
Hey Kelven,
Will upgraded setups need to destroy/reboot console proxy VMs to have
the new encryption scheme take effect? Or this is entirely seamless?
Thanks,
--
Prasanna.,
On Tue, Apr 16, 2013 at 12:39:17AM +0000, Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10533/
> -----------------------------------------------------------
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> Improve console access security with 128-bit AES encryption and securely-randomized key generation
>
>
> This addresses bug CLOUDSTACK-2039.
>
>
> Diffs
> -----
>
> console-proxy/src/com/cloud/consoleproxy/ConsoleProxyPasswordBasedEncryptor.java 29826f0
> server/src/com/cloud/configuration/Config.java 0815a77
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 168ac0e
> server/src/com/cloud/server/ManagementServer.java 5c34dee
> server/src/com/cloud/server/ManagementServerImpl.java 9cddb77
> server/src/com/cloud/servlet/ConsoleProxyPasswordBasedEncryptor.java 2638c8b
> server/src/com/cloud/servlet/ConsoleProxyServlet.java c4b9334
>
> Diff: https://reviews.apache.org/r/10533/diff/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Kelven Yang
>