You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "TisonKun (JIRA)" <ji...@apache.org> on 2019/07/26 15:44:00 UTC
[jira] [Comment Edited] (FLINK-13334) Remove legacy implementation
of slot
[ https://issues.apache.org/jira/browse/FLINK-13334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16893922#comment-16893922 ]
TisonKun edited comment on FLINK-13334 at 7/26/19 3:43 PM:
-----------------------------------------------------------
Change the purpose of this JIRA into remove the whole legacy slot implement because legacy slot sharing is used in it and I find we can do it at once.
was (Author: tison):
Change the purpose of this JIRA into remove the whole legacy slot implement because legacy slot sharing is used in it and I find we can do it in batch.
> Remove legacy implementation of slot
> ------------------------------------
>
> Key: FLINK-13334
> URL: https://issues.apache.org/jira/browse/FLINK-13334
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Affects Versions: 1.10.0
> Reporter: TisonKun
> Assignee: TisonKun
> Priority: Major
> Fix For: 1.10.0
>
>
> cc [~till.rohrmann] [~srichter]
> From my investigation currently Flink use {{SlotSharingManager}} and {{SlotSharingGroupId}} for achieving slot sharing. And thus {{SlotSharingGroupAssignment}} {{SlotSharingGroup}} and {{SharedSlot}} are all legacy concept.
> Notice that the ongoing scheduler re-design touches frequently tests based on legacy slot/instance logic or even uses it for testing. I'd like to nudge this process for totally remove legacy code from our code base.
> Also I attach a patch on FLINK-12179 that remove {{Instance}}. With current contribution workflow your shepherds are significant :- )
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)