You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/10/10 03:07:19 UTC
[jira] Created: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
[classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
------------------------------------------------------------------------------------------
Key: HARMONY-1790
URL: http://issues.apache.org/jira/browse/HARMONY-1790
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
I'll upload a patch to clean exception check code. thanks!
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=all ]
Paulex Yang reopened HARMONY-1790:
----------------------------------
Seems the patch of this issue caused two error of RandomFileTest, roll it back at revision r463302.
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1790-updated.diff, Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=all ]
Andrew Zhang updated HARMONY-1790:
----------------------------------
Attachment: Harmony-1790.diff
Hi,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=comments#action_12441774 ]
Andrew Zhang commented on HARMONY-1790:
---------------------------------------
Hi Paulex,
the fix looks fine. Thanks!
Best regards,
Andrew
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1790-updated.diff, Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=all ]
Paulex Yang resolved HARMONY-1790.
----------------------------------
Resolution: Fixed
Andrew, patch applied at revision r463239, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1790-updated.diff, Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=all ]
Andrew Zhang updated HARMONY-1790:
----------------------------------
Attachment: Harmony-1790-updated.diff
Please try Harmony-1790-updated.diff please, thank you!
Best regards,
Andrew
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: Harmony-1790-updated.diff, Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=all ]
Paulex Yang resolved HARMONY-1790.
----------------------------------
Resolution: Fixed
Andrew, the tweaked patch applied at revision r463681, I restored the "0==count" check to make the tests pass on Linux, please verify the problem is fully resoved as expected, thank you.
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1790-updated.diff, Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=all ]
Paulex Yang reassigned HARMONY-1790:
------------------------------------
Assignee: Paulex Yang
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Paulex Yang
> Priority: Minor
> Attachments: Harmony-1790-updated.diff, Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1790) [classlib][io] remove duplicated
exception check in RandomAccessFile#write(byte, int, int)
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1790?page=comments#action_12441030 ]
Andrew Zhang commented on HARMONY-1790:
---------------------------------------
There are already lots of tests on exceptional cases, therefore, no regression test is included in this patch.
Thanks!
> [classlib][io] remove duplicated exception check in RandomAccessFile#write(byte, int, int)
> ------------------------------------------------------------------------------------------
>
> Key: HARMONY-1790
> URL: http://issues.apache.org/jira/browse/HARMONY-1790
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: Harmony-1790.diff
>
>
> Noticed that there're some duplicated exception check in RandomAccessFile#write(byte, int, int).
> I'll upload a patch to clean exception check code. thanks!
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira