You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/04/21 02:56:58 UTC
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1452: feat(Ranger): Use Apache Ranger for ACL when replica performs nfs copy
empiredan commented on code in PR #1452:
URL: https://github.com/apache/incubator-pegasus/pull/1452#discussion_r1173255498
##########
src/replica/replica_stub.h:
##########
@@ -270,6 +274,39 @@ class replica_stub : public serverlet<replica_stub>, public ref_counter
fs_manager *get_fs_manager() { return &_fs_manager; }
+ template <typename TReqType, typename TRespType>
+ bool check_status_and_authz_with_reply(const TReqType &request,
+ ::dsn::rpc_replier<TRespType> &reply,
+ const ::dsn::ranger::access_type &ac_type)
+ {
+ if (!_access_controller->is_enable_ranger_acl()) {
Review Comment:
`is_enable_ranger_acl()` could also be declared as const ?
##########
src/replica/replica_stub.h:
##########
@@ -270,6 +274,39 @@ class replica_stub : public serverlet<replica_stub>, public ref_counter
fs_manager *get_fs_manager() { return &_fs_manager; }
+ template <typename TReqType, typename TRespType>
+ bool check_status_and_authz_with_reply(const TReqType &request,
+ ::dsn::rpc_replier<TRespType> &reply,
+ const ::dsn::ranger::access_type &ac_type)
Review Comment:
```suggestion
const ::dsn::ranger::access_type &ac_type) const
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org