You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/08 05:05:59 UTC

[GitHub] [calcite] xndai commented on a change in pull request #1963: [CALCITE-3976] Generify the DefaultEdge class

xndai commented on a change in pull request #1963:
URL: https://github.com/apache/calcite/pull/1963#discussion_r421940125



##########
File path: core/src/main/java/org/apache/calcite/materialize/Lattice.java
##########
@@ -513,11 +513,11 @@ public boolean isAlwaysMeasure(Column column) {
     }
 
     Vertex getTarget() {
-      return (Vertex) target;
+      return target;

Review comment:
       Can we just make source() and target() base class methods? So these can be removed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org