You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/14 13:09:36 UTC

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #318: [FLINK-28478] Always complete in-progress update

gyfora opened a new pull request, #318:
URL: https://github.com/apache/flink-kubernetes-operator/pull/318

   ## What is the purpose of the change
   
   Fix bug where session upgrade would not be completed if an exception was thrown directly before submission.
   
   ## Brief change log
   
   Fix invalid logic in AbstractFlinkResourceReconciler#checkNewSpecAlreadyDeployed to always return false in UPGRADING state.
   
   ## Verifying this change
   
   Added new cases to SessionReconcilerTest to cover this failure scenrio
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: (no)
     - Core observer or reconciler logic that is regularly executed: (yes)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #318: [FLINK-28478] Always complete in-progress update

Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #318:
URL: https://github.com/apache/flink-kubernetes-operator/pull/318#issuecomment-1184429432

   cc @morhidi @Aitozi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #318: [FLINK-28478] Always complete in-progress update

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #318:
URL: https://github.com/apache/flink-kubernetes-operator/pull/318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org