You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/17 04:30:33 UTC

[GitHub] [mynewt-newtmgr] nkaje commented on pull request #162: Optimize DFU

nkaje commented on pull request #162:
URL: https://github.com/apache/mynewt-newtmgr/pull/162#issuecomment-629741596


   > I wrote a lot of comments here, but most of them are minor. Overall I like the idea and I think it is sound.
   > 
   > One thing I did not mention in my comments is naming convention. Golang uses camelCase, period. I really dislike camel case so I can sympathize here, but it is not a matter of preference, it is built in to the language. Capitalization determines an identifier's scope.
   
   I have revisited the change and used CamelCase where I think it is appropriate. Please let me know if I missed anything.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org