You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 18:35:37 UTC
[jira] [Created] (HADOOP-8173) FsShell needs to handle quoted
metachars
FsShell needs to handle quoted metachars
----------------------------------------
Key: HADOOP-8173
URL: https://issues.apache.org/jira/browse/HADOOP-8173
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 0.24.0, 0.23.2
Reporter: Daryn Sharp
Assignee: Daryn Sharp
Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex. {{fs -mkdir "foo\ *bar"}} will create {{foo\ *bar}} instead of {{foo*bar}}.
(note: there's really no space between \ and *, jira munches \ )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230566#comment-13230566 ]
Daryn Sharp commented on HADOOP-8173:
-------------------------------------
The only one that looked questionable was a trailing \ not being removed. I've been mimicking the shell, and it looks like it's happy with it:
{noformat}
$ touch 'a\' && ls -l a*
-rw-r--r-- 1 daryn daryn 0 Mar 15 16:17 a\
{noformat}
It's also the same regexp used internally by globbing, so it's consistent.
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230706#comment-13230706 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1890 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1890/])
HADOOP-8173. FsShell needs to handle quoted metachars. Contributed by Daryn Sharp (Revision 1301250)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301250
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230663#comment-13230663 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1881 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1881/])
HADOOP-8173. FsShell needs to handle quoted metachars. Contributed by Daryn Sharp (Revision 1301250)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301250
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-8173:
-------------------------------------------
Description:
Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
{noformat}
fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
{noformat}
was:
Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex. {{fs -mkdir "foo\ *bar"}} will create {{foo\ *bar}} instead of {{foo*bar}}.
(note: there's really no space between \ and *, jira munches \ )
Target Version/s: 0.24.0, 0.23.2 (was: 0.23.2, 0.24.0)
Revised description: Use noformat.
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230717#comment-13230717 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #694 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/694/])
svn merge -c 1301250 from trunk for HADOOP-8173. (Revision 1301251)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301251
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8173:
--------------------------------
Attachment: (was: HDFS-3098.patch)
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex. {{fs -mkdir "foo\ *bar"}} will create {{foo\ *bar}} instead of {{foo*bar}}.
> (note: there's really no space between \ and *, jira munches \ )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8173:
--------------------------------
Target Version/s: 0.24.0, 0.23.2 (was: 0.23.2, 0.24.0)
Status: Patch Available (was: Open)
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex. {{fs -mkdir "foo\ *bar"}} will create {{foo\ *bar}} instead of {{foo*bar}}.
> (note: there's really no space between \ and *, jira munches \ )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Arun C Murthy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-8173:
----------------------------------
Fix Version/s: (was: 0.24.0)
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230502#comment-13230502 ]
Hadoop QA commented on HADOOP-8173:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518519/HADOOP-8173.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.ipc.TestRPCCallBenchmark
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/713//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/713//console
This message is automatically generated.
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231155#comment-13231155 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #227 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/227/])
svn merge -c 1301250 from trunk for HADOOP-8173. (Revision 1301251)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301251
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230675#comment-13230675 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #677 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/677/])
svn merge -c 1301250 from trunk for HADOOP-8173. (Revision 1301251)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301251
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230679#comment-13230679 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #686 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/686/])
svn merge -c 1301250 from trunk for HADOOP-8173. (Revision 1301251)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301251
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230779#comment-13230779 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1958 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1958/])
HDFS-3098. Update and add tests for HADOOP-8173. Contributed by Daryn Sharp (Revision 1301295)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301295
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231147#comment-13231147 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #199 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/199/])
svn merge -c 1301250 from trunk for HADOOP-8173. (Revision 1301251)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301251
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8173:
--------------------------------
Attachment: HDFS-3098.patch
Add tests to ensure quoted metas are taken literally. List directories with *s. Create dir with a * subdir & regular subdir. Delete the * subdir. Ensure other subdir was not caught by a glob and still exists.
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch, HDFS-3098.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex. {{fs -mkdir "foo\ *bar"}} will create {{foo\ *bar}} instead of {{foo*bar}}.
> (note: there's really no space between \ and *, jira munches \ )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230784#comment-13230784 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1884 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1884/])
HDFS-3098. Update and add tests for HADOOP-8173. Contributed by Daryn Sharp (Revision 1301295)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301295
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-8173:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.2
0.24.0
Target Version/s: 0.24.0, 0.23.2 (was: 0.23.2, 0.24.0)
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Daryn!
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-8173:
-------------------------------------------
Target Version/s: 0.24.0, 0.23.2 (was: 0.23.2, 0.24.0)
Hadoop Flags: Reviewed
+1 on the patch.
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231128#comment-13231128 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #986 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/986/])
HDFS-3098. Update and add tests for HADOOP-8173. Contributed by Daryn Sharp (Revision 1301295)
HADOOP-8173. FsShell needs to handle quoted metachars. Contributed by Daryn Sharp (Revision 1301250)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301295
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301250
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230670#comment-13230670 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1956 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1956/])
HADOOP-8173. FsShell needs to handle quoted metachars. Contributed by Daryn Sharp (Revision 1301250)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301250
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8173:
--------------------------------
Attachment: HADOOP-8173.patch
In the event that a path does not exist, and it is not a glob, strip the quoting of metachars.
Tests will be included via the linked HDFS-3098.
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex. {{fs -mkdir "foo\ *bar"}} will create {{foo\ *bar}} instead of {{foo*bar}}.
> (note: there's really no space between \ and *, jira munches \ )
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230545#comment-13230545 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8173:
------------------------------------------------
I tested it with the following:
{code}
public static void main(String[] args) throws IOException {
File f = new File("a.txt");
final BufferedReader in = new BufferedReader(new FileReader(f));
for(String line; (line = in.readLine()) != null;) {
testPattern(line);
}
}
static String testPattern(String s) {
System.out.print("replace " + s);
s = s.replaceAll("\\\\(.)", "$1");
System.out.println(" to " + s);
return s;
}
{code}
and the result is
{noformat}
replace foo* to foo*
replace foo\* to foo*
replace foo\\* to foo\*
replace foo\\\* to foo\*
replace foo\ to foo\
replace foo\\ to foo\
replace foo\\\ to foo\\
replace foo\** to foo**
replace foo*bar to foo*bar
replace foo\*bar to foo*bar
replace foo\\*bar to foo\*bar
replace foo\\\*bar to foo\*bar
replace foo\bar to foobar
replace foo\\bar to foo\bar
replace foo\\\bar to foo\bar
replace foo\**bar to foo**bar
replace foo*bar* to foo*bar*
replace foo\*bar\* to foo*bar*
replace foo\\*bar\\* to foo\*bar\*
replace foo\\\*bar\\\* to foo\*bar\*
replace foo\bar\ to foobar\
replace foo\\bar\\ to foo\bar\
replace foo\\\bar\\\ to foo\bar\\
replace foo\**bar\** to foo**bar**
{noformat}
Do you think that they are all expected?
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230808#comment-13230808 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1892 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1892/])
HDFS-3098. Update and add tests for HADOOP-8173. Contributed by Daryn Sharp (Revision 1301295)
Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301295
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8173) FsShell needs to handle quoted
metachars
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231198#comment-13231198 ]
Hudson commented on HADOOP-8173:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1021 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1021/])
HDFS-3098. Update and add tests for HADOOP-8173. Contributed by Daryn Sharp (Revision 1301295)
HADOOP-8173. FsShell needs to handle quoted metachars. Contributed by Daryn Sharp (Revision 1301250)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301295
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testHDFSConf.xml
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301250
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/PathData.java
> FsShell needs to handle quoted metachars
> ----------------------------------------
>
> Key: HADOOP-8173
> URL: https://issues.apache.org/jira/browse/HADOOP-8173
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0, 0.23.2
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.24.0, 0.23.2
>
> Attachments: HADOOP-8173.patch
>
>
> Commands that access paths with quoted metachars work correctly, however commands that create paths with quoted metachars leave the \ in the path. Ex.
> {noformat}
> fs -mkdir "foo\*bar" will create "foo\*bar" instead of "foo*bar".
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira