You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by aa...@apache.org on 2019/02/13 22:40:20 UTC
[incubator-pinot] branch master updated: [TE] frontend -
aaronucsd/update endpoint names to subscription (#3831)
This is an automated email from the ASF dual-hosted git repository.
aaronucsd pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8524ca4 [TE] frontend - aaronucsd/update endpoint names to subscription (#3831)
8524ca4 is described below
commit 8524ca4fdf617200be78dee9e5ec3bbddc0c33d9
Author: Long Huynh <lo...@linkedin.com>
AuthorDate: Wed Feb 13 14:40:15 2019 -0800
[TE] frontend - aaronucsd/update endpoint names to subscription (#3831)
---
.../app/pods/components/alert-details/template.hbs | 53 ----------------------
.../app/pods/components/yaml-editor/component.js | 8 ++--
.../app/pods/components/yaml-editor/template.hbs | 6 +--
3 files changed, 7 insertions(+), 60 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs
index ce133a8..c26f846 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/template.hbs
@@ -229,57 +229,4 @@
{{/unless}}
<p>{{errorAnomalies}}</p>
{{yield}}
-
-
-
-
-
-
-
-
- <!-- {{#if isPendingData}}
- <div>
- {{ember-spinner scale=0.5 rotate=10 speed='1.1' color='#3498DB'}}Please wait while we compiled the data.
- </div>
- {{else}}
- {{#if disableYamlSave}}
- {{range-pill-selectors
- title="Showing"
- uiDateFormat=pill.uiDateFormat
- activeRangeEnd=pill.activeRangeEnd
- activeRangeStart=pill.activeRangeStart
- timeRangeOptions=pill.timeRangeOptions
- timePickerIncrement=pill.timePickerIncrement
- predefinedRanges=pill.predefinedRanges
- selectAction=(action "onRangeSelection")
- }}
- <div class="te-horizontal-cards">
- <h4 class="te-self-serve__block-title">
- <label for="select-dimension" class="control-label te-label">
- Alert Performance
- <span>
- <i class="glyphicon glyphicon-question-sign"></i>
- {{#tooltip-on-element class="te-tooltip"}}
- All estimated performance numbers are based on reviewed anomalies.
- {{/tooltip-on-element}}
- </span>
- </label>
- </h4>
- <div class="te-horizontal-cards__container">
- {{!-- Alert anomaly stats cards --}}
- {{stats-cards stats=stats}}
- </div>
-
- {{#if repRunStatus}}
- <p class="te-self-serve__block-subtext te-self-serve__block-subtext--normal">Replay in progress. Please check back later...</p>
- {{/if}}
- </div>
- {{else}}
- <div class="yaml-editor-msg">Alert configuration has changed.</div>
- <label class="control-label te-label">
- <a {{action "refreshPreview"}}>Refresh Preview</a>
- </label>
- {{/if}}
- {{/if}}
- {{yield}} -->
</div>
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
index 435ad59..26bf14c 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
@@ -268,7 +268,7 @@ export default Component.extend({
const yamlAlertProps = get(this, 'yamlAlertProps');
set(this, 'alertYaml', yamlAlertProps);
}
- } else if (field === 'notification') {
+ } else if (field === 'subscription') {
if(isEditMode) {
set(this, 'detectionSettingsYaml', get(this, 'currentYamlSettingsOriginal'));
} else {
@@ -290,7 +290,7 @@ export default Component.extend({
},
/**
- * Updates the notification settings yaml with user section
+ * Updates the subscription settings yaml with user section
*/
onYAMLGroupSelectionAction(value) {
if(value.yaml) {
@@ -368,7 +368,7 @@ export default Component.extend({
createAlertYamlAction() {
const content = {
detection: get(this, 'alertYaml'),
- notification: get(this, 'detectionSettingsYaml')
+ subscription: get(this, 'detectionSettingsYaml')
};
const url = '/yaml/create-alert';
const postProps = {
@@ -428,7 +428,7 @@ export default Component.extend({
}
//PUT settings
- const setting_url = `/yaml/notification/${subscriptionGroupId}`;
+ const setting_url = `/yaml/subscription/${subscriptionGroupId}`;
const settingsPostProps = {
method: 'PUT',
body: detectionSettingsYaml,
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
index dc948c1..0610a82 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/template.hbs
@@ -87,20 +87,20 @@
defaultText="Reset"
type="outline-primary"
buttonType="reset"
- onClick=(action "resetYAML" "notification")
+ onClick=(action "resetYAML" "subscription")
class="te-button te-button--link"
}}
{{bs-button
defaultText="View Documentation"
type="outline-primary"
buttonType="link"
- onClick=(action "triggerDoc" "Notification")
+ onClick=(action "triggerDoc" "subscription")
class="te-button te-button--cancel"
}}
</div>
</div>
<div class="col-xs-12">
- {{!-- notification settings editor --}}
+ {{!-- subscription settings editor --}}
{{ember-ace
lines=25
value=currentYamlSettings
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org