You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "tinaselenge (via GitHub)" <gi...@apache.org> on 2023/08/10 08:22:04 UTC
[GitHub] [kafka] tinaselenge opened a new pull request, #14184: KAFKA-15201: When git fails, the script goes into a loop
tinaselenge opened a new pull request, #14184:
URL: https://github.com/apache/kafka/pull/14184
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tinaselenge commented on pull request #14184: KAFKA-15201: When git fails, the script goes into a loop
Posted by "tinaselenge (via GitHub)" <gi...@apache.org>.
tinaselenge commented on PR #14184:
URL: https://github.com/apache/kafka/pull/14184#issuecomment-1673077828
@divijvaidya I'm sorry, I realise this doesn't fix the issue. `cmd` function that executes git push takes optional parameters such as `num_retries` and `allow_failure`. When these are not passed which is the case for git push command, `num_retries` is set to 0 and `allow_failure` is set to false. This should result in failing without any retry. Do you have any logs when this happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tinaselenge closed pull request #14184: KAFKA-15201: When git fails, the script goes into a loop
Posted by "tinaselenge (via GitHub)" <gi...@apache.org>.
tinaselenge closed pull request #14184: KAFKA-15201: When git fails, the script goes into a loop
URL: https://github.com/apache/kafka/pull/14184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #14184: KAFKA-15201: When git fails, the script goes into a loop
Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14184:
URL: https://github.com/apache/kafka/pull/14184#issuecomment-1672871528
Thank you for picking this up @tinaselenge. Can you please help me understand in the description why the script was going in a loop and how does this PR fix it? It would also be nice if you can consider if other git push statements in the file require similar changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org