[GitHub] [httpcomponents-core] ok2c commented on pull request #394: Add support for Internationalized Domain Names (IDN)

["ok2c (via GitHub)" <gi...@apache.org>]

ok2c commented on PR #394:
URL: https://github.com/apache/httpcomponents-core/pull/394#issuecomment-1498796044

   @arturobernalg I have to say I did not do a good job reviewing your original change-set. With your changes one could create instances of `Host` class referring to the same IDN host but with and without IDN encoding. That was wrong and could potentially lead to various issues with IDN hostnames. 
   
   I changed the internal representation of the hostname to Unicode and added IDN conversion to those routines that parse hostnames from text or format them back. This way the internal representation is always consistent regardless of the original representation or formatting.
   
   I re-committed your original change-set as 716f64c744d227bca80d8ee6a0a5cc951a5910d9. Please review. This should also make apache/httpcomponents-client#431 unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org