You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by "impetus technologies (JIRA)" <ji...@apache.org> on 2008/11/06 08:01:45 UTC

[jira] Created: (SHINDIG-677) ValidateUrl using Zend url validation in ProxyHandler

ValidateUrl using Zend url validation in ProxyHandler 
------------------------------------------------------

                 Key: SHINDIG-677
                 URL: https://issues.apache.org/jira/browse/SHINDIG-677
             Project: Shindig
          Issue Type: Improvement
          Components: Gadget Rendering Server (PHP)
            Reporter: impetus technologies
         Attachments: ProxyHandler.patch

validateUrl() funaction was empty and expected some code to check URL. I have used Zend url to check the url. 

Patch is attached. Kindly review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHINDIG-677) ValidateUrl using Zend url validation in ProxyHandler

Posted by "impetus technologies (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHINDIG-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

impetus technologies updated SHINDIG-677:
-----------------------------------------

    Attachment: ProxyHandler.patch

> ValidateUrl using Zend url validation in ProxyHandler 
> ------------------------------------------------------
>
>                 Key: SHINDIG-677
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-677
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>            Reporter: impetus technologies
>         Attachments: ProxyHandler.patch
>
>
> validateUrl() funaction was empty and expected some code to check URL. I have used Zend url to check the url. 
> Patch is attached. Kindly review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (SHINDIG-677) ValidateUrl using Zend url validation in ProxyHandler

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHINDIG-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-677.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

I'm afraid I ended up committing a slightly different fix:

The Zend URI parser (and anything in the zend libs really) are so heavy handed code wise, that using Zend's URI validation reduced the amount of proxied requests / second by about 50% (from ~600 to ~300 on my MPB), and that's while running opcode-caches etc.

So instead I've implemented the function using parse_url, which isn't as strict as Zend's uri parser (it accepts quite a bit of cruft and only rejects really broken urls), but it doesn't have any negative performance impacts.. 50% was to much of a performance hit for a slightly better validation.





> ValidateUrl using Zend url validation in ProxyHandler 
> ------------------------------------------------------
>
>                 Key: SHINDIG-677
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-677
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (PHP)
>            Reporter: impetus technologies
>            Assignee: Chris Chabot
>         Attachments: ProxyHandler.patch
>
>
> validateUrl() funaction was empty and expected some code to check URL. I have used Zend url to check the url. 
> Patch is attached. Kindly review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.