You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/08/21 15:54:09 UTC
Review Request 61785: When Matching New VDFs for Parent Repos only
Consider STANDARD Types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61785/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko and Nate Cole.
Bugs: AMBARI-21766
https://issues.apache.org/jira/browse/AMBARI-21766
Repository: ambari
Description
-------
When registering a {{MAINT}} VDF where the regex matches both an existing {{STANDARD}} and existing {{PATCH}} repository, the new VDF registration will fail with:
{quote}
{
"status": 400,
"message": "Patch 2.5.4.0-121 was found to match more than one repository in use: 2.5.0.0-1237, 2.5.4.0-121. Move all services to a common version and try again."
}
{quote}
We should only be matching for parents against the {{STANDARD}} repo type.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ea592e50af
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java 40bbd072f2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java aed0aafbc2
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java d41b0ba144
Diff: https://reviews.apache.org/r/61785/diff/1/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 61785: When Matching New VDFs for Parent Repos only
Consider STANDARD Types
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61785/#review183355
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 21, 2017, 11:54 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61785/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 11:54 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-21766
> https://issues.apache.org/jira/browse/AMBARI-21766
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When registering a {{MAINT}} VDF where the regex matches both an existing {{STANDARD}} and existing {{PATCH}} repository, the new VDF registration will fail with:
> {quote}
> {
> "status": 400,
> "message": "Patch 2.5.4.0-121 was found to match more than one repository in use: 2.5.0.0-1237, 2.5.4.0-121. Move all services to a common version and try again."
> }
> {quote}
>
> We should only be matching for parents against the {{STANDARD}} repo type.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java ea592e50af
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java 40bbd072f2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java aed0aafbc2
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java d41b0ba144
>
>
> Diff: https://reviews.apache.org/r/61785/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>