[GitHub] yurmix commented on issue #6430: Contributing Moving-Average Query to open source.

[GitBox <gi...@apache.org>]

yurmix commented on issue #6430: Contributing Moving-Average Query to open source.
URL: https://github.com/apache/incubator-druid/pull/6430#issuecomment-466632938
 
 
   > @yurmix thanks for the nice PR! I'm still looking at, but have a question for the general design.
   > 
   > Why do we need a new query type for moving average? Rather, can we generalize `Averager` and `PostAverager` to support any types of queries like `PostAggregator`? This question is related to `MovingAverageQueryRunner`. It internally generates a query and computes moving average on top of it. I don't think this is necessary, but we can generalize this logic similar to `PostAggregator`.
   
   I completely agree the work could be incorporated within the general Query. The reason it was created as a separate query type is for the sake of easier implementation (due to the separation of concerns). Calling the underlying query through an internal API is easier than making those changes directly to `Queries` or another class. Perhaps refactoring it into the core query framework could be a future work?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org