You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jeff Sposetti <je...@hortonworks.com> on 2015/05/14 22:11:39 UTC

Review Request 34230: Sample view for auto-cluster create that uses Ambari REST API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34230/
-----------------------------------------------------------

Review request for Ambari, Tom Beerbower and Yusaku Sako.


Bugs: AMBARI-11141
    https://issues.apache.org/jira/browse/AMBARI-11141


Repository: ambari


Description
-------

Provide a sample view that show how to auto-create + configure a view instance that can access the Ambari REST API from a view.


Diffs
-----

  ambari-views/examples/README.md ec1226e 
  ambari-views/examples/auto-cluster-view/docs/index.md PRE-CREATION 
  ambari-views/examples/auto-cluster-view/pom.xml PRE-CREATION 
  ambari-views/examples/auto-cluster-view/src/main/java/org/apache/ambari/view/examples/AutoClusterService.java PRE-CREATION 
  ambari-views/examples/auto-cluster-view/src/main/resources/ui/index.html PRE-CREATION 
  ambari-views/examples/auto-cluster-view/src/main/resources/view.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/34230/diff/


Testing
-------


Thanks,

Jeff Sposetti


Re: Review Request 34230: Sample view for auto-cluster create that uses Ambari REST API

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34230/#review83848
-----------------------------------------------------------

Ship it!


Looks good.

- Tom Beerbower


On May 14, 2015, 9:46 p.m., Jeff Sposetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34230/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 9:46 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-11141
>     https://issues.apache.org/jira/browse/AMBARI-11141
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Provide a sample view that show how to auto-create + configure a view instance that can access the Ambari REST API from a view.
> 
> 
> Diffs
> -----
> 
>   ambari-views/examples/README.md ec1226e 
>   ambari-views/examples/auto-cluster-view/docs/index.md PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/pom.xml PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/src/main/java/org/apache/ambari/view/examples/AutoClusterService.java PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/src/main/resources/ui/index.html PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Sposetti
> 
>


Re: Review Request 34230: Sample view for auto-cluster create that uses Ambari REST API

Posted by Jeff Sposetti <je...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34230/
-----------------------------------------------------------

(Updated May 14, 2015, 9:46 p.m.)


Review request for Ambari, Tom Beerbower and Yusaku Sako.


Bugs: AMBARI-11141
    https://issues.apache.org/jira/browse/AMBARI-11141


Repository: ambari


Description
-------

Provide a sample view that show how to auto-create + configure a view instance that can access the Ambari REST API from a view.


Diffs (updated)
-----

  ambari-views/examples/README.md ec1226e 
  ambari-views/examples/auto-cluster-view/docs/index.md PRE-CREATION 
  ambari-views/examples/auto-cluster-view/pom.xml PRE-CREATION 
  ambari-views/examples/auto-cluster-view/src/main/java/org/apache/ambari/view/examples/AutoClusterService.java PRE-CREATION 
  ambari-views/examples/auto-cluster-view/src/main/resources/ui/index.html PRE-CREATION 
  ambari-views/examples/auto-cluster-view/src/main/resources/view.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/34230/diff/


Testing
-------


Thanks,

Jeff Sposetti


Re: Review Request 34230: Sample view for auto-cluster create that uses Ambari REST API

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34230/#review83836
-----------------------------------------------------------



ambari-views/examples/auto-cluster-view/src/main/resources/view.xml
<https://reviews.apache.org/r/34230/#comment134916>

    If I understand correctly, these parameters are here to trick the UI into allowing a manual cluster association.  If so, do we need all three?  Wouldn't just having the first parameter accomplish the same?
    
    I still don't really like that we have to use the 'fake' cluster-config.


- Tom Beerbower


On May 14, 2015, 8:11 p.m., Jeff Sposetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34230/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 8:11 p.m.)
> 
> 
> Review request for Ambari, Tom Beerbower and Yusaku Sako.
> 
> 
> Bugs: AMBARI-11141
>     https://issues.apache.org/jira/browse/AMBARI-11141
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Provide a sample view that show how to auto-create + configure a view instance that can access the Ambari REST API from a view.
> 
> 
> Diffs
> -----
> 
>   ambari-views/examples/README.md ec1226e 
>   ambari-views/examples/auto-cluster-view/docs/index.md PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/pom.xml PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/src/main/java/org/apache/ambari/view/examples/AutoClusterService.java PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/src/main/resources/ui/index.html PRE-CREATION 
>   ambari-views/examples/auto-cluster-view/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeff Sposetti
> 
>