[GitHub] [incubator-doris] xinghuayu007 commented on pull request #4809: 【BUG】Catch runtime exception

[GitBox <gi...@apache.org>]

xinghuayu007 commented on pull request #4809:
URL: https://github.com/apache/incubator-doris/pull/4809#issuecomment-717773236


   The RunTimeException is throwed by this function, not a real RunTimeException.
   
   ```
   public static int compareLiteralExpr(LiteralExpr key1, LiteralExpr key2) {
           int ret = 0;
           if (key1 instanceof MaxLiteral || key2 instanceof MaxLiteral) {
               ret = key1.compareLiteral(key2);
           } else {
               final Type destType = Type.getAssignmentCompatibleType(key1.getType(), key2.getType(), false);
               try {
                   LiteralExpr newKey = key1;
                   if (key1.getType() != destType) {
                       newKey = (LiteralExpr) key1.castTo(destType);
                   }
                   LiteralExpr newOtherKey = key2;
                   if (key2.getType() != destType) {
                       newOtherKey = (LiteralExpr) key2.castTo(destType);
                   }
                   ret = newKey.compareLiteral(newOtherKey);
               } catch (AnalysisException e) {
                  *************** throw new RuntimeException("Cast error in partition"); ******************
               }
           }
           return ret;
       }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org