You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 18:42:59 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #12003: chore: remove generic type
betodealmeida opened a new pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
We were passing a generics type that is actually not needed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
N/A
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6c59303) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.17%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 63.76% +0.17%
==========================================
Files 940 467 -473
Lines 45575 28574 -17001
Branches 4373 0 -4373
==========================================
- Hits 28984 18221 -10763
+ Misses 16415 10353 -6062
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.76% <ø> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.35% <0.00%> (-2.78%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.14% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.85%)` | :arrow_down: |
| ... and [479 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.85%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 62.73% -0.86%
==========================================
Files 940 473 -467
Lines 45575 16999 -28576
Branches 4373 4373
==========================================
- Hits 28984 10665 -18319
+ Misses 16415 6158 -10257
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <50.00%> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [superset/migrations/versions/705732c70154\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83MDU3MzJjNzAxNTRfLnB5) | | |
| [superset/security/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvX19pbml0X18ucHk=) | | |
| [superset/examples/multi\_line.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | | |
| [superset/css\_templates/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | | |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | | |
| ... and [459 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.52%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 64.12% +0.52%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18335 -10649
+ Misses 16415 10259 -6156
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.12% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | | |
| [.../src/dashboard/components/menu/WithPopoverMenu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvV2l0aFBvcG92ZXJNZW51LmpzeA==) | | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | | |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
| [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1B1Ymxpc2hlZFN0YXR1cy5qc3g=) | | |
| ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.45%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.42% -3.46%
==========================================
Files 948 471 -477
Lines 46177 28970 -17207
Branches 4405 0 -4405
==========================================
- Hits 31348 18665 -12683
+ Misses 14722 10305 -4417
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.42% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.61% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.33% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **not change** coverage.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
=======================================
Coverage 63.59% 63.59%
=======================================
Files 940 940
Lines 45575 45575
Branches 4373 4373
=======================================
Hits 28984 28984
Misses 16415 16415
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <50.00%> (ø)` | |
| python | `64.10% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.56% -3.32%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18715 -12633
+ Misses 14722 10270 -4452
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.56% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.75% <0.00%> (-0.65%)` | :arrow_down: |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Nob3VsZFdyYXBDaGlsZEluUm93Lmpz) | | |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | | |
| [...frontend/src/dashboard/util/newEntitiesFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL25ld0VudGl0aWVzRnJvbURyb3AuanM=) | | |
| [superset-frontend/src/showSavedQuery/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Nob3dTYXZlZFF1ZXJ5L3V0aWxzLmpz) | | |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
| [superset-frontend/src/SqlLab/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb25zdGFudHMudHM=) | | |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | | |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlTm9kZXNUcmVlLmpz) | | |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.50%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 63.09% -0.51%
==========================================
Files 940 940
Lines 45575 45575
Branches 4373 4373
==========================================
- Hits 28984 28755 -229
- Misses 16415 16644 +229
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <50.00%> (ø)` | |
| python | `63.30% <ø> (-0.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.87%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.49%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 63.09% -0.50%
==========================================
Files 940 940
Lines 45575 45560 -15
Branches 4373 4373
==========================================
- Hits 28984 28748 -236
- Misses 16415 16636 +221
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <50.00%> (ø)` | |
| python | `63.31% <ø> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.87%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.43%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 63.16% -0.44%
==========================================
Files 940 467 -473
Lines 45575 28579 -16996
Branches 4373 0 -4373
==========================================
- Hits 28984 18052 -10932
+ Misses 16415 10527 -5888
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.16% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [499 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.56% -3.32%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18715 -12633
+ Misses 14722 10270 -4452
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.56% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.75% <0.00%> (-0.65%)` | :arrow_down: |
| [.../dashboard/util/logging/findNonTabChildChartIds.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZE5vblRhYkNoaWxkQ2hhcnRJZHMuanM=) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | | |
| [...rset-frontend/src/components/AsyncEsmComponent.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNFc21Db21wb25lbnQudHN4) | | |
| [superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmxhc2hQcm92aWRlci50c3g=) | | |
| [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | | |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | | |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | | |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `4.25%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 63.63% -4.26%
==========================================
Files 948 471 -477
Lines 46177 28970 -17207
Branches 4405 0 -4405
==========================================
- Hits 31348 18435 -12913
+ Misses 14722 10535 -4187
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [495 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.49%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.39% -3.50%
==========================================
Files 948 471 -477
Lines 46177 28970 -17207
Branches 4405 0 -4405
==========================================
- Hits 31348 18655 -12693
+ Misses 14722 10315 -4407
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.39% <ø> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.61% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.33% <0.00%> (-0.01%)` | :arrow_down: |
| ... and [478 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.56% -3.32%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18715 -12633
+ Misses 14722 10270 -4452
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.56% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.75% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [superset-frontend/src/components/CheckboxIcons.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3hJY29ucy50c3g=) | | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | | |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| [...rc/explore/components/controls/ColorMapControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvck1hcENvbnRyb2wuanN4) | | |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | | |
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.91%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 63.97% -3.92%
==========================================
Files 948 948
Lines 46177 46167 -10
Branches 4405 4405
==========================================
- Hits 31348 29536 -1812
- Misses 14722 16453 +1731
- Partials 107 178 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.96% <50.00%> (ø)` | |
| python | `64.57% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (-10.90%)` | :arrow_down: |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [171 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 63.90% +0.31%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18274 -10710
+ Misses 16415 10320 -6095
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.90% <ø> (-0.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.80% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.24% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [476 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.56% -3.32%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18715 -12633
+ Misses 14722 10270 -4452
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.56% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.75% <0.00%> (-0.65%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | | |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | | |
| [...uperset-frontend/src/components/FacePile/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvdXRpbHMudHN4) | | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | | |
| [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=) | | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | | |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.91%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 63.96% -3.92%
==========================================
Files 948 471 -477
Lines 46177 28970 -17207
Branches 4405 0 -4405
==========================================
- Hits 31348 18532 -12816
+ Misses 14722 10438 -4284
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.96% <ø> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.52%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 64.12% +0.52%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18335 -10649
+ Misses 16415 10259 -6156
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.12% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [...d/src/visualizations/TimeTable/FormattedNumber.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9Gb3JtYXR0ZWROdW1iZXIuanN4) | | |
| [...ews/CRUD/annotationlayers/AnnotationLayersList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJzTGlzdC50c3g=) | | |
| [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | | |
| [superset-frontend/src/utils/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2Rvd25sb2FkQXNJbWFnZS50cw==) | | |
| [superset-frontend/src/profile/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvaW5kZXgudHN4) | | |
| ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (771a033) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.34%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 63.94% +0.34%
==========================================
Files 940 467 -473
Lines 45575 28576 -16999
Branches 4373 0 -4373
==========================================
- Hits 28984 18273 -10711
+ Misses 16415 10303 -6112
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.94% <ø> (-0.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.14%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | | |
| [...-frontend/src/components/Select/Select.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC5zdG9yaWVzLnRzeA==) | | |
| [.../src/dashboard/components/BuilderComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0J1aWxkZXJDb21wb25lbnRQYW5lLmpzeA==) | | |
| [...t-frontend/src/views/CRUD/data/query/QueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeUxpc3QudHN4) | | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | | |
| ... and [466 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...771a033](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.31%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.56% -3.32%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18715 -12633
+ Misses 14722 10270 -4452
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.56% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.75% <0.00%> (-0.65%)` | :arrow_down: |
| [.../src/explore/components/controls/HiddenControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9IaWRkZW5Db250cm9sLmpzeA==) | | |
| [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | | |
| [...nd/src/dashboard/util/findTabIndexByComponentId.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRUYWJJbmRleEJ5Q29tcG9uZW50SWQuanM=) | | |
| [...frontend/src/dashboard/components/MissingChart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL01pc3NpbmdDaGFydC5qc3g=) | | |
| [...uperset-frontend/src/common/components/Tooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAudHN4) | | |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | | |
| [...-frontend/src/dashboard/util/isDashboardLoading.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkTG9hZGluZy5qcw==) | | |
| ... and [465 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.14%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 63.45% -0.15%
==========================================
Files 940 940
Lines 45575 45575
Branches 4373 4373
==========================================
- Hits 28984 28920 -64
- Misses 16415 16479 +64
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <50.00%> (ø)` | |
| python | `63.88% <ø> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `57.23% <33.33%> (ø)` | |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.75% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 63.47% -0.12%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18151 -10833
+ Misses 16415 10443 -5972
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.47% <ø> (-0.63%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.26% <0.00%> (-1.63%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.24% <0.00%> (-0.47%)` | :arrow_down: |
| ... and [479 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (5a8933a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/916f7e923aed50e44d3a981f8b684021fd85da40?el=desc) (916f7e9) will **decrease** coverage by `3.30%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 67.88% 64.57% -3.31%
==========================================
Files 948 471 -477
Lines 46177 28985 -17192
Branches 4405 0 -4405
==========================================
- Hits 31348 18718 -12630
+ Misses 14722 10267 -4455
+ Partials 107 0 -107
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.57% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGlzdFZpZXcudHN4) | | |
| [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | | |
| [...uperset-frontend/src/components/FacePile/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmFjZVBpbGUvdXRpbHMudHN4) | | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | | |
| [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=) | | |
| [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | | |
| ... and [464 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [916f7e9...5a8933a](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742717257
cc: @eschutho
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.52%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 64.12% +0.52%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18335 -10649
+ Misses 16415 10259 -6156
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `64.12% <ø> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/components/ListView/Filters/Search.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9TZWFyY2gudHN4) | | |
| [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | | |
| [...set-frontend/src/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==) | | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | | |
| ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `3.95%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 67.54% +3.95%
==========================================
Files 940 940
Lines 45575 45585 +10
Branches 4373 4373
==========================================
+ Hits 28984 30791 +1807
+ Misses 16415 14689 -1726
+ Partials 176 105 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.61% <66.66%> (?)` | |
| javascript | `62.73% <50.00%> (ø)` | |
| python | `64.10% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `68.12% <33.33%> (+10.89%)` | :arrow_up: |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `74.24% <0.00%> (-1.15%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `73.03% <0.00%> (-0.83%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.24% <0.00%> (-0.65%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `52.22% <0.00%> (+1.11%)` | :arrow_up: |
| ... and [170 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6c59303) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.17%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 63.77% +0.17%
==========================================
Files 940 467 -473
Lines 45575 28576 -16999
Branches 4373 0 -4373
==========================================
- Hits 28984 18223 -10761
+ Misses 16415 10353 -6062
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.77% <ø> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.35% <0.00%> (-2.78%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.14% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.75% <0.00%> (-1.85%)` | :arrow_down: |
| ... and [477 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (771a033) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
- Coverage 63.59% 63.51% -0.08%
==========================================
Files 940 467 -473
Lines 45575 28576 -16999
Branches 4373 0 -4373
==========================================
- Hits 28984 18151 -10833
+ Misses 16415 10425 -5990
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.51% <ø> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.14%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | | |
| [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | | |
| ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...771a033](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (193ac0f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `3.84%`.
> The diff coverage is `50.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 67.44% +3.84%
==========================================
Files 940 940
Lines 45575 45585 +10
Branches 4373 4373
==========================================
+ Hits 28984 30743 +1759
+ Misses 16415 14733 -1682
+ Partials 176 109 -67
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.12% <66.66%> (?)` | |
| javascript | `62.73% <50.00%> (ø)` | |
| python | `64.10% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `68.12% <33.33%> (+10.89%)` | :arrow_up: |
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `74.24% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `89.36% <0.00%> (-1.95%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `74.24% <0.00%> (-1.15%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `73.03% <0.00%> (-0.83%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.24% <0.00%> (-0.65%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (+1.06%)` | :arrow_up: |
| ... and [168 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...193ac0f](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12003: chore: remove generic type
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12003:
URL: https://github.com/apache/incubator-superset/pull/12003#issuecomment-742729872
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=h1) Report
> Merging [#12003](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=desc) (6ed48a4) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12003/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12003 +/- ##
==========================================
+ Coverage 63.59% 63.96% +0.36%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18289 -10695
+ Misses 16415 10305 -6110
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.96% <ø> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.61% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.64% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <0.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [474 more](https://codecov.io/gh/apache/incubator-superset/pull/12003/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=footer). Last update [9256b6f...6ed48a4](https://codecov.io/gh/apache/incubator-superset/pull/12003?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org