You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/02 14:13:44 UTC

[GitHub] [james-site] jeantil opened a new pull request #13: [JAMES-3226] drops unused ui-bundle

jeantil opened a new pull request #13:
URL: https://github.com/apache/james-site/pull/13


   It seems that an effort to use an customized UI bundle was started and abandonned halfway. The bundle currently isn't used in the website generation and can confuse contributors. 
   
   I propose to remove them, since the modifications it contain can now be replicated by using antora supplementary files to override the default UI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #13:
URL: https://github.com/apache/james-site/pull/13#issuecomment-812854449


   @chibenwa I updated this PR with a couple commits demonstrating how to customize UI, the demo is a proof of concept I didn't spend too much time on styling the icons for example, some of the links are not perfect but it shows how it's done :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on a change in pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #13:
URL: https://github.com/apache/james-site/pull/13#discussion_r606705723



##########
File path: doc-sites/package-lock.json
##########
@@ -5,29 +5,37 @@
   "requires": true,

Review comment:
       
   According to the [documentation](https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json)
   ```
   package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates.
   ```
   
   So we do need to commit both package.json and package.lock.json




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] chibenwa merged pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #13:
URL: https://github.com/apache/james-site/pull/13


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #13:
URL: https://github.com/apache/james-site/pull/13#issuecomment-814128055


   ideally I would prefer to have this merged before merging to live and hard resetting staging :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #13:
URL: https://github.com/apache/james-site/pull/13#issuecomment-812581002


   I think we should keep antora-ui for now I am experimenting with different schemes for modifying the UI I'll do a followup cleanup PR once I have something working in a satisfying way


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] chibenwa commented on a change in pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #13:
URL: https://github.com/apache/james-site/pull/13#discussion_r606674313



##########
File path: doc-sites/package-lock.json
##########
@@ -5,29 +5,37 @@
   "requires": true,

Review comment:
       I'm js naive but shouldn't package.json be ignored?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on a change in pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #13:
URL: https://github.com/apache/james-site/pull/13#discussion_r606705723



##########
File path: doc-sites/package-lock.json
##########
@@ -5,29 +5,37 @@
   "requires": true,

Review comment:
       According to the [documentation](https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json)
   
   > package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, 
    or package.json. It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates.
   
   
   So we do need to commit both package.json and package.lock.json




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] chibenwa commented on pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #13:
URL: https://github.com/apache/james-site/pull/13#issuecomment-814217562


   Yes, I did not want to hurry too ;uch to give a chance for over people to review this.
   
   I am unsure how many people are actively watching this repository.
   
   I will merge it now, it is several days already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #13:
URL: https://github.com/apache/james-site/pull/13#issuecomment-812919694


   ![Screenshot from 2021-04-03 22-07-37](https://user-images.githubusercontent.com/22979/113490408-f5e9a700-94c9-11eb-864f-25dd877838a9.png)
   ![Screenshot from 2021-04-03 22-07-34](https://user-images.githubusercontent.com/22979/113490409-f6823d80-94c9-11eb-9c15-adeb6895ed4e.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org

[GitHub] [james-site] jeantil commented on pull request #13: [JAMES-3226] drops unused ui-bundle

Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #13:
URL: https://github.com/apache/james-site/pull/13#issuecomment-812919776


   ![Screenshot from 2021-04-03 22-15-00](https://user-images.githubusercontent.com/22979/113490423-0c8ffe00-94ca-11eb-9f8e-425a47e83efa.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org