You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/09/08 11:08:28 UTC

[GitHub] [calcite] rubenada commented on pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

rubenada commented on PR #2899:
URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240569016

   @thomasrebele the code is arguably simpler. There is no need to maintain two different data structures (a map plus a list), just a single map fulfills all our needs. IMO this is less error-prone, in the future someone may need to modify the map, and might forget about updating the list (or vice-versa).
   It is true that the memory usage can be higher, but I would not expect this to have a huge impact on the overall performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org