You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/12/07 10:06:17 UTC

[PR] Fix: Fail to run route with toD #4972 [camel-k]

claudio4j opened a new pull request, #4976:
URL: https://github.com/apache/camel-k/pull/4976

   Fix https://github.com/apache/camel-k/issues/4972
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   Enhancement of the dependency calculation for dynamic endpoints
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Fail to run route with toD #4972 [camel-k]

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4976:
URL: https://github.com/apache/camel-k/pull/4976#issuecomment-1845233954

   > LGTM, however I am not understanding how this is solving the issue. 
   
   This fix only the parsing bug, as the `toD` notation allows a flexible placeholder, so instead to check only the ending of the string, it if the remaining scheme contains the ending placeholder.
   
   > I mean, we still will need to include the component dependency manually, right?
   
   Yes, the camel-k dependency resolver is mostly a regexp parsing the strings, which in the case of the placeholder is not know at this time, only when the code is parsed by camel-core (after camel-k operator build).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Fail to run route with toD #4972 [camel-k]

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #4976:
URL: https://github.com/apache/camel-k/pull/4976#issuecomment-1849016536

   The only CI error check is fixed by #4957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Fail to run route with toD #4972 [camel-k]

Posted by "MotaOcimar (via GitHub)" <gi...@apache.org>.
MotaOcimar commented on PR #4976:
URL: https://github.com/apache/camel-k/pull/4976#issuecomment-1847195546

   Hi @squakez! Thanks for reviewing!
   
   The full discussion of the issue is at [this Zulip topic](https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/Help.20with.20.60--build-property.60/near/406165252).
   
   But in short, the following route doesn't work even if we specify the camel-http dependency:
   
   ```xml
   <route id="start-route">
       <from uri="timer:my-timer"/>
       <setBody>
           <constant>Hello!</constant>
       </setBody>
       <toD uri="{{endpoint}}/test"/>
   </route>
   ```
   
   If we remove `/test` from the path it works, exemplifying the parsing bug.
   
   I'm hoping it will be approved until the next release 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix: Fail to run route with toD #4972 [camel-k]

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j merged PR #4976:
URL: https://github.com/apache/camel-k/pull/4976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org