You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2016/02/16 14:09:01 UTC
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1642
[FLINK-3299] Remove ApplicationID from Environment
As per discussion in the issue, we decided to remove the the `ApplicationID`.
Replaces the app ID in RocksDB and DB backend with job ID. I've talked to @gyfora about the DB backend and he mentioned a possible problem with savepoints in certain corner cases, but all in all the change should be OK.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 3299-app_id
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1642
----
commit f88e4d540b71f9a4e683b44a030ad6b267f132cb
Author: Ufuk Celebi <uc...@apache.org>
Date: 2016-02-11T15:04:08Z
[FLINK-3299] Remove ApplicationID from Environment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-184755784
The `CompletedCheckpoint` comes from the `CheckpointCoordinator`. Savepoints are the same thing. Therefore I would keep it as it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-184728030
should we maybe rename the CompletedCheckpoint class to Savepoint? the naming appears a bit incoonsistent now that the Savepoint class is removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-184683583
In general the DbStateBackend should not misbehave under the current assumptions. What Ufuk means is that the DbStateBackend does not make any assumption about the job parallelism if using the App id (we could change the job parallelism). This will not hold now but it does not matter as we don't support this feature yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-185205104
OK, I'm going to merge this then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1642#discussion_r53023536
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/SavepointCoordinatorTest.java ---
@@ -337,19 +326,14 @@ public void testRollbackStateStoreFailure() throws Exception {
@Test
public void testRollbackUpdatesApplicationID() throws Exception {
--- End diff --
test method should renamed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-184677192
What would that corner case be?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3299] Remove ApplicationID from Environ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-185199936
Looks reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---