You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/02/06 11:50:49 UTC

[GitHub] incubator-gearpump pull request #138: [GEARPUMP-23] Refactor Window DSL

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/138

    [GEARPUMP-23] Refactor Window DSL

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump window_dsl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit 30083a16d03278355817fc49420561a7b7abf0d8
Author: manuzhang <ow...@gmail.com>
Date:   2017-02-06T11:44:56Z

    [GEARPUMP-23] Refactor Window DSL

commit 6e766821df152037f8cafe246b67098d6070e25e
Author: manuzhang <ow...@gmail.com>
Date:   2017-02-06T11:47:35Z

    [GEARPUMP-23] Fix style

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #138: [GEARPUMP-23] Refactor Window DSL

Posted by huafengw <gi...@git.apache.org>.

Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/138
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #138: [GEARPUMP-23] Refactor Window DSL

Posted by manuzhang <gi...@git.apache.org>.

Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/138
  
    R: @huafengw 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #138: [GEARPUMP-23] Refactor Window DSL

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---